Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yearly undiscoverable bps rewards #1151

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Yearly undiscoverable bps rewards #1151

merged 2 commits into from
Feb 9, 2023

Conversation

Torresmorah
Copy link
Collaborator

Add yearly rewards in the undiscoverable bps section

What does this PR do?

Steps to test

  1. Run the project locally.
  2. Go to undiscoverable bps page.
  3. Check the yearly rewards.

Screenshots

Undiscoverable BPs section

Yearly Rewards

Width of 1820 px
imagen

Width of 1920 px
imagen

Rewards Distribution section

Before
imagen

After
imagen

@@ -106,7 +103,7 @@ const NonCompliantCard = ({ producer, stats }) => {
<Typography variant="overline">{t('dailyRewards')}</Typography>
<RowInfo
title={`${t('rewards')} (USD)`}
value={`$${formatWithThousandSeparator(
value={`$ ${formatWithThousandSeparator(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the space between the dollar sign and number to maintain cosistency with other views
It also makes the text shprter
image

image

image

Copy link

@maemultichain maemultichain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are elements very stuck to others, we need to adjust the margin spaces.

@xavier506 xavier506 merged commit 035e644 into dev Feb 9, 2023
@xavier506 xavier506 deleted the feat/yearly-rewards-1134 branch February 9, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add yearly non-compliant BP rewards
3 participants