Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use Client.session attribute where possible #921

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Aug 2, 2023


📚 Documentation preview 📚: https://citric--921.org.readthedocs.build/en/921/

@trunk-io
Copy link

trunk-io bot commented Aug 2, 2023

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c886663) 100.00% compared to head (2eae3ae) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #921   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          403       403           
  Branches        23        23           
=========================================
  Hits           403       403           
Files Changed Coverage Δ
src/citric/client.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 2, 2023 23:57
@edgarrmondragon edgarrmondragon merged commit 67f8c14 into main Aug 2, 2023
32 checks passed
@edgarrmondragon edgarrmondragon deleted the refactor/use-session-attribute branch August 2, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant