A refactor of the script. #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added more picture links
added more picture links
fixed the parser for normal scrub
# - Added Frag%, Size, Allocated, Free for ZPool status report summary. # - Added Disk Size, RPM, Model to the Smart Report # - Added if statment so that if "Model Family" is not present script will use "Device Model" # for brand in the SMART Satus report details. # - Added Glabel Status Report (RAW) # - Removed Power-On time labels and added ":" as a separator. # - Added Power-On format to the Power-On time Header. # - Changed Backup deafult to false.
Ids are standardized (mostly) but names are not. Fixes #3.
* aserrallerios/master: Rebase v1.6 to main repo Fixes for TrueNAS 12.0-RELEASE Adapted script because output of zpool status changed added line breaks to disk info table body
Only use smart 321 when both 231 and 233 are present.
HTML boundary fix & proper message ids Better support for NVMe and SSD Support for new smartmon-tools
This also uses a function and is much easier to read.
Ordered by apearence.
Use current names.
Also note drives that do not support test monitoring through smartctl. Refs #20.
512 because apparently the NVMe spec uses magic numbers.
* topic/scale: Add a custom message for a missing `bc`. Fix white space. -q does not work on debian. 10^ is more portable than 1e. Get a more human readable status dump. md5sum and sha256sum are on both scale and core. nvmecontrol is bsd only. Better drive list for scale. Having a date field that takes almost anything is pain. debain date does not like _ Account for different `date` invocations. Another command to test. First pass at linux changes; untested. glabel is not used on scale.
Refs #22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to make it easier to read, more maintainable, and to solve several outstanding issues.
To do (help welcome):
Fixes #27.
Fixes #25.
Fixes #21.
Fixes #7.
Fixes #3.
Fixes #33.