Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sync PRs and Fix bugs] For platforms: AS4630-54TE, AS5835-54X, AS7326-56X, AS7726-32X, AS9716-32D, and AS9736-64D #46

Merged
merged 97 commits into from
May 28, 2024

Conversation

tigerfu000
Copy link

@tigerfu000 tigerfu000 commented May 23, 2024

Why I did it

To support harden version platforms.

How I did it

=== Sync PRs ===

Sync platform PRs from sonic-net:

Sync common PMBus driver from below PRs (only sync files: ym2651y.c, accton_psu_api.h, and accton_psu_defs.h)(3eca9aa):

=== Fix bugs ===

(39a071c)[Platform]: Adjust stable size parameter of SDK for as4630_54te.
(15525af)[Platform][AS7326-56X][AS7726-32X]: Fix pytest of port toggle test item failed.

How to verify it

Run testcases on testbed.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202305

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

jostar-yang and others added 30 commits April 23, 2024 18:16
Signed-off-by: jostar-yang <jostar_yang@edge-core.com>
Signed-off-by: michael_shih <michael_shih@edge-core.com>
Signed-off-by: michael_shih <michael_shih@edge-core.com>
Signed-off-by: jostar-yang <jostar_yang@edge-core.com>
Signed-off-by: michael_shih <michael_shih@edge-core.com>
Signed-off-by: michael_shih <michael_shih@edge-core.com>
as4630_54te:
  1. Fix wrong fan direction
  2. Fix wrong get_status_led()
  3. Fix wrong get_status() when psu power good failed

as5835_54x:
  1. Fix wrong get_status_led()
  2. Fix wrong get_status() when psu power good failed
  3. Fix wrong sysfs path of rear fan

Signed-off-by: Brandon Chuang <brandon_chuang@edge-core.com>
Signed-off-by: jostar-yang <jostar_yang@edge-core.com>
ec-michael-shih and others added 26 commits April 24, 2024 15:04
…sync buffer to disk first.

[Why to modify]:
After doing cpu shutown and power-cycle, we'll find syslog loss shutdown message.
So need to do sync buffer to disk command first.

Signed-off-by: michael_shih <michael_shih@edge-core.com>
Why I did it
Buster is EOL, and the backports section has been removed from the main Debian repos. This also means that our default mirror (for non-snapshot builds) is also affected.

Work item tracking
Microsoft ADO (number only): 27691460
How I did it
Change to using archive.debian.org directly for Buster.

How to verify it
In some local buildings, an error /bin/bash: line 0: cd: src/sonic-dash-api/sonic-dash-api: No such file or directory will be raised due to the directory structure of sonic-dash-api has been changed.

Signed-off-by: Ze Gan <ganze718@gmail.com>
Detail:
  platformbroadcom/sonic-platform-modules-accton/as4630-54te/modules/accton_psu_api.h
  platform/broadcom/sonic-platform-modules-accton/as4630-54te/modules/accton_psu_defs.h
2. sync disk data before shutdown DUT
Signed-off-by: michael_shih <michael_shih@accton.com>
Why I did it:
    After DUT starts up, the syncd cannot work.
    And, the syslog will indicate:
      - ERR syncd#syncd: [none] SAI_API_SWITCH:platform_process_command:430 Platform command "init bcm" failed, rc = -1.
      - INFO syncd#supervisord: syncd Scache on unit 0 exhausted the stable_size of 76303156#015

How I dit it:
    Modify SDK configuration file of as4630_54te (followed as4630_54pe)

How to verify it:
    Check syncd is running normally after DUT starts up, and no related error syslog exists.
Why I did it:
    Testbed test reports related PSU test failed.

How I dit it:
    Sync PMBUS driver from:
    - sonic-net/sonic-buildimage#13815
    - edge-core#6
    - edge-core#23

How to verify it:
    show platform firmware
    show platform syseeprom
    show platform psustatus
    show platform temperature
    show platform fan
…em failed.

Why I did it:
    Testbed pytest port toggle failed on topology t0.
    When deploy t0's minigraph by 'config load_minigraph -y',
    the syncd occurs error so that most docker containers(synd, swss, ...) are not running.
    And the syslog exists the below entry:
    - ERR syncd#syncd: [none] SAI_API_NEXT_HOP_GROUP:brcm_sai_xgs_nexthop_group_create:113 ecmp nh group create failed with error Feature unavailable (0xfffffff0)

How I dit it:
    Setup broadcom soc property l3_ecmp_levels=2 refer to as4630-54pe, as4630-54te, and as5835-54x.

How to verify it:
    Re-run pytest port toggle is pass and no syncd sai feature unavailable log exists in syslog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.