[Subport] Fix issues on portsorch.cpp #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peter-yu Please rewrite the headline to describe what the code change for |
1. [Subport] Keep vlan tag when add member port into portchannel of subport When add member port into portchannel, if the portchannel has subport interface, the port should keep the vlan tag. 2. Handle HostIntfsStripTag properly removeBridgePort should check port.m_child_ports.empty() before HostIntfsStripTag(,SAI_HOSTIF_VLAN_TAG_STRIP). 3. fix ERR syslog while test_subport setup/teardown fix 2: config portchannel add PortChannel1 config interface ip add PortChannel1.40 100.40.40.40/24 config interface ip remove PortChannel1.40 100.40.40.40/24 config portchannel del PortChannel1 syslog: Dec 27 15:01:38.336049 as5812-54x NOTICE swss#orchagent: :- removeRouterIntfs: Router interface is still referenced Dec 27 15:01:38.337833 as5812-54x ERR swss#orchagent: :- meta_generic_validation_remove: object 0x2000000000a81 reference count is 1, can't remove Dec 27 15:01:38.338038 as5812-54x ERR swss#orchagent: :- removeLag: Failed to remove LAG PortChannel1 lid:2000000000a81 root cause: portchannel is still reference by subport solution: PortsOrch::doLagTask, op == DEL_COMMAND ===== fix 3: syslog: Dec 24 17:28:01.030970 as5812-54x ERR swss#orchagent: :- meta_sai_validate_oid: oid is set to null object id on SAI_OBJECT_TYPE_LAG_MEMBER Dec 24 17:28:01.031218 as5812-54x ERR swss#orchagent: :- setCollectionOnLagMember: Failed to enable collection on LAG member Ethernet28 root cause: PortsOrch::setCollectionOnLagMember/ setDistributionOnLagMember, check lag member id
|
@gord1306 commit headline updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When add member port into portchannel, if the portchannel has subport interface, the port should keep the vlan tag.
removeBridgePort should check port.m_child_ports.empty() before HostIntfsStripTag(,SAI_HOSTIF_VLAN_TAG_STRIP).
fix 2:
config portchannel add PortChannel1
config interface ip add PortChannel1.40 100.40.40.40/24
config interface ip remove PortChannel1.40 100.40.40.40/24 config portchannel del PortChannel1
syslog:
Dec 27 15:01:38.336049 as5812-54x NOTICE swss#orchagent: :- removeRouterIntfs: Router interface is still referenced Dec 27 15:01:38.337833 as5812-54x ERR swss#orchagent: :- meta_generic_validation_remove: object 0x2000000000a81 reference count is 1, can't remove Dec 27 15:01:38.338038 as5812-54x ERR swss#orchagent: :- removeLag: Failed to remove LAG PortChannel1 lid:2000000000a81
root cause:
portchannel is still reference by subport
solution: PortsOrch::doLagTask, op == DEL_COMMAND
=====
fix 3:
syslog:
Dec 24 17:28:01.030970 as5812-54x ERR swss#orchagent: :- meta_sai_validate_oid: oid is set to null object id on SAI_OBJECT_TYPE_LAG_MEMBER Dec 24 17:28:01.031218 as5812-54x ERR swss#orchagent: :- setCollectionOnLagMember: Failed to enable collection on LAG member Ethernet28
root cause:
PortsOrch::setCollectionOnLagMember/ setDistributionOnLagMember, check lag member id
What I did
Why I did it
How I verified it
Details if related