Replace old actix-web with axum #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tweaks the Agora context type we use in order to avoid a recurring Rust compiler bug (rust-lang/rust#71723) which makes it suddenly impossible to carry the context across an await. This comes at the cost of increasing String allocations. Though the use of snmalloc mitigates this cost somewhat.
cmwhited
approved these changes
Apr 12, 2023
graph-gateway/src/main.rs
Outdated
| CorsLayer::new() | ||
| .allow_origin(cors::Any) | ||
| .allow_headers(cors::Any) | ||
| .allow_methods([http::Method::POST, http::Method::OPTIONS]), |
There was a problem hiding this comment.
Does the gateway serve the graphql schema inspection for a subgraph? If so, do we also need to allow GET here?
There was a problem hiding this comment.
I only see us handling POST in the route handlers. But want to validate.
There was a problem hiding this comment.
Nope the gateway doesn't do schema inspection, and previsously only allowed POST & OPTIONS. I just tested this out without setting OPTIONS here, and it seems to work as expected. Fixed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move away from the outdated actix-web version we've been stuck on since the Rust rewrite. Use axum instead.
Closes #300