WIP: Improve and simplify Deno compatibility #632
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work In Progress – I'm aiming to remove all "custom" Deno build logic here in favor of Denoify.
packages/driver
packages/generate
???
I've taken some liberties with things like changing file naming conventions in favor of Denoify's default pattern, where
foobar.deno.ts
is the Deno replacement forfoobar.ts
. Previously, it's beenfoobar.node.ts
andfoobar.deno.ts
explicitly.A bunch of minor cosmetic changes to appease the Deno linter.
Ended up removing
driver/.../globals.deno.ts
because I couldn't figure out what it was for...?Explicitly import Node.js builtins, e.g.
import { Buffer } from "buffer"
because Denoify needs it to do its thing. Ideally, I'd want to usenode:buffer
style imports, Denoify actually turns that intonode:node:buffer
, so I'm holding off on that.