Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Improve and simplify Deno compatibility #632

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

denizdogan
Copy link

@denizdogan denizdogan commented Jun 8, 2023

Work In Progress – I'm aiming to remove all "custom" Deno build logic here in favor of Denoify.

  • packages/driver

  • packages/generate

  • ???

  • I've taken some liberties with things like changing file naming conventions in favor of Denoify's default pattern, where foobar.deno.ts is the Deno replacement for foobar.ts. Previously, it's been foobar.node.ts and foobar.deno.ts explicitly.

  • A bunch of minor cosmetic changes to appease the Deno linter.

  • Ended up removing driver/.../globals.deno.ts because I couldn't figure out what it was for...?

  • Explicitly import Node.js builtins, e.g. import { Buffer } from "buffer" because Denoify needs it to do its thing. Ideally, I'd want to use node:buffer style imports, Denoify actually turns that into node:node:buffer, so I'm holding off on that.

@edgedb-cla
Copy link

edgedb-cla bot commented Jun 8, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@denizdogan
Copy link
Author

Started doing this after discussion in #599, please let me know what you think so far, especially if it looks like I'm unknowingly about to break compatibility with something important.

@denizdogan
Copy link
Author

I should add that the reason why I've added deno_dist is that it seems like it's kind of required in order to publish this to deno.land? If there's no simple way around it, that kind of sucks, but I'm sure we can figure it out somehow.

TSError:
src/baseConn.ts:533:9 - error TS2454: Variable 'inTypeId' is used before being assigned.
src/baseConn.ts:533:29 - error TS2454: Variable 'outTypeId' is used before being assigned.
src/baseConn.ts:619:9 - error TS2454: Variable 'cardinality' is used before being assigned.
@denizdogan denizdogan force-pushed the denizdogan/denoify branch 3 times, most recently from b718b86 to 2a22a5e Compare June 9, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant