Deprecate Pool.acquire() and Pool.release() #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start moving client API toward a pool centric design.
elprans
reviewed
Aug 11, 2021
Co-authored-by: Elvis Pranskevichus <elvis@edgedb.com>
1st1
reviewed
Aug 12, 2021
1st1
reviewed
Aug 12, 2021
1st1
pushed a commit
that referenced
this pull request
Aug 12, 2021
elprans
added a commit
that referenced
this pull request
Nov 12, 2021
Changes ======= * support protocol version 0.12 (by @fmoor in 5ce52ed) * Update to protocol version 0.13 (by @1st1 in c690250, 8by @fmoor in 5ce52ed, by @jaclarke in a5a6218 for #253) * Lookup edgedb.toml recursively in parent directories (by @fmoor in d9a12b8 for #245) * Update connection parameter resolution (by @jaclarke in 085f574 for #241) * Implement EDGEDB_CLIENT_SECURITY (by @fmoor in ac46c37) * Add optional/required `query_single*` methods + rename `retrying_transaction` + update pool to `create_client` API (by @jaclarke in f2ae0d0 for #249) Deprecations ============ * Deprecate Pool.acquire() and Pool.release() (by @fmoor in 2d501e9 for #217) * Rename tls_verify_hostname to tls_security (by @fmoor in 2086b86) Fixes ===== * Do not attempt to del transport in connection_lost if it has been already (by @elprans in c719e79 for #215) * Retry if start() raises a retryable error (#228) (by @fantix in ffaae01 for #228) * Fix broken pool connection cleanup (by @fantix in be44959 for #222) * Fix deprecated usage of SSLContext (#231) (by @elprans in f73f999 for #231) * Bugfix: _borrowed_for is now set entering a transaction (#233) (by @fantix in bf763d1 for #233) * Send zero arguments as zero-length bytes in proto 0.12 (#238) (by @tailhook in f51dd51 for #238) * Fix retrying_transaction() on network errors (by @fmoor in cc001e6) * Fix connection and retry options on AsyncIOPool (#237) (by @tailhook in 44e279f for #237) * Auto retry read-only queries outside transactions (#243) (by @fmoor in 76bb586 for #243) * Fix `credentials_file` argument typo on `async_connect` (#252) (by @mkniewallner in b21b70a for #252)
elprans
added a commit
that referenced
this pull request
Nov 12, 2021
Changes ======= * support protocol version 0.12 (by @fmoor in 5ce52ed) * Update to protocol version 0.13 (by @1st1 in c690250, 8by @fmoor in 5ce52ed, by @jaclarke in a5a6218 for #253) * Lookup `edgedb.toml` recursively in parent directories (by @fmoor in d9a12b8 for #245) * Update connection parameter resolution (by @jaclarke in 085f574 for #241) * Implement `EDGEDB_CLIENT_SECURITY` (by @fmoor in ac46c37) * Add optional/required `query_single*` methods + rename `retrying_transaction` + update pool to `create_client` API (by @jaclarke in f2ae0d0 for #249) Deprecations ============ * Deprecate `Pool.acquire()` and `Pool.release()` (by @fmoor in 2d501e9 for #217) * Rename `tls_verify_hostname` to `tls_security` (by @fmoor in 2086b86) Fixes ===== * Do not attempt to del transport in `connection_lost` if it has been already (by @elprans in c719e79 for #215) * Retry if `start()` raises a retryable error (#228) (by @fantix in ffaae01 for #228) * Fix broken pool connection cleanup (by @fantix in be44959 for #222) * Fix deprecated usage of `SSLContext` (#231) (by @elprans in f73f999 for #231) * Bugfix: `_borrowed_for` is now set entering a transaction (#233) (by @fantix in bf763d1 for #233) * Send zero arguments as zero-length bytes in proto 0.12 (#238) (by @tailhook in f51dd51 for #238) * Fix `retrying_transaction()` on network errors (by @fmoor in cc001e6) * Fix connection and retry options on `AsyncIOPool` (#237) (by @tailhook in 44e279f for #237) * Auto retry read-only queries outside transactions (#243) (by @fmoor in 76bb586 for #243) * Fix `credentials_file` argument typo on `async_connect` (#252) (by @mkniewallner in b21b70a for #252)
Merged
elprans
added a commit
that referenced
this pull request
Nov 12, 2021
Changes ======= * support protocol version 0.12 (by @fmoor in 5ce52ed) * Update to protocol version 0.13 (by @1st1 in c690250, 8by @fmoor in 5ce52ed, by @jaclarke in a5a6218 for #253) * Lookup `edgedb.toml` recursively in parent directories (by @fmoor in d9a12b8 for #245) * Update connection parameter resolution (by @jaclarke in 085f574 for #241) * Implement `EDGEDB_CLIENT_SECURITY` (by @fmoor in ac46c37) * Add optional/required `query_single*` methods + rename `retrying_transaction` + update pool to `create_client` API (by @jaclarke in f2ae0d0 for #249) Deprecations ============ * Deprecate `Pool.acquire()` and `Pool.release()` (by @fmoor in 2d501e9 for #217) * Rename `tls_verify_hostname` to `tls_security` (by @fmoor in 2086b86) Fixes ===== * Do not attempt to del transport in `connection_lost` if it has been already (by @elprans in c719e79 for #215) * Retry if `start()` raises a retryable error (#228) (by @fantix in ffaae01 for #228) * Fix broken pool connection cleanup (by @fantix in be44959 for #222) * Fix deprecated usage of `SSLContext` (#231) (by @elprans in f73f999 for #231) * Bugfix: `_borrowed_for` is now set entering a transaction (#233) (by @fantix in bf763d1 for #233) * Send zero arguments as zero-length bytes in proto 0.12 (#238) (by @tailhook in f51dd51 for #238) * Fix `retrying_transaction()` on network errors (by @fmoor in cc001e6) * Fix connection and retry options on `AsyncIOPool` (#237) (by @tailhook in 44e279f for #237) * Auto retry read-only queries outside transactions (#243) (by @fmoor in 76bb586 for #243) * Fix `credentials_file` argument typo on `async_connect` (#252) (by @mkniewallner in b21b70a for #252)
elprans
added a commit
that referenced
this pull request
Nov 12, 2021
Changes ======= * support protocol version 0.12 (by @fmoor in 5ce52ed) * Update to protocol version 0.13 (by @1st1 in c690250, 8by @fmoor in 5ce52ed, by @jaclarke in a5a6218 for #253) * Lookup `edgedb.toml` recursively in parent directories (by @fmoor in d9a12b8 for #245) * Update connection parameter resolution (by @jaclarke in 085f574 for #241) * Implement `EDGEDB_CLIENT_SECURITY` (by @fmoor in ac46c37) * Add optional/required `query_single*` methods + rename `retrying_transaction` + update pool to `create_client` API (by @jaclarke in f2ae0d0 for #249) Deprecations ============ * Deprecate `Pool.acquire()` and `Pool.release()` (by @fmoor in 2d501e9 for #217) * Rename `tls_verify_hostname` to `tls_security` (by @fmoor in 2086b86) Fixes ===== * Do not attempt to del transport in `connection_lost` if it has been already (by @elprans in c719e79 for #215) * Retry if `start()` raises a retryable error (#228) (by @fantix in ffaae01 for #228) * Fix broken pool connection cleanup (by @fantix in be44959 for #222) * Fix deprecated usage of `SSLContext` (#231) (by @elprans in f73f999 for #231) * Bugfix: `_borrowed_for` is now set entering a transaction (#233) (by @fantix in bf763d1 for #233) * Send zero arguments as zero-length bytes in proto 0.12 (#238) (by @tailhook in f51dd51 for #238) * Fix `retrying_transaction()` on network errors (by @fmoor in cc001e6) * Fix connection and retry options on `AsyncIOPool` (#237) (by @tailhook in 44e279f for #237) * Auto retry read-only queries outside transactions (#243) (by @fmoor in 76bb586 for #243) * Fix `credentials_file` argument typo on `async_connect` (#252) (by @mkniewallner in b21b70a for #252)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start moving client API toward a pool centric design.