Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum values #425

Merged
merged 1 commit into from
May 26, 2023
Merged

Fix enum values #425

merged 1 commit into from
May 26, 2023

Conversation

fantix
Copy link
Member

@fantix fantix commented Apr 21, 2023

User-defined enums can be used interchangably with edgedb.EnumValue, like the __eq__ (==) test, __hash__ (as dict key) or comparing will pass between user enum and edgedb.EnumValue, but the is check won't pass.

This fixes a typing issue in the codegen. Fixes #419

@fantix fantix requested a review from 1st1 April 21, 2023 00:21
User-defined enums can be used interchangably with edgedb.EnumValue,
like the `__eq__` (`==`) test, `__hash__` (as dict key) or comparing
will pass between user enum and edgedb.EnumValue, but the `is` check
won't pass.

This fixes a typing issue in the codegen. Fixes #419
@fantix fantix merged commit bb7522c into master May 26, 2023
@fantix fantix deleted the enum-arg branch May 26, 2023 14:48
fantix added a commit that referenced this pull request Jun 19, 2024
New Features
============

* Support EdgeDB 5.0 "branch" connection option
  (by @vpetrovykh in #484 #485 #487)

* Support EdgeDB 5.0 AI extension
  (by @fantix in #489 #490)

Breaking Changes
================

* Enum values can now compare to user-defined enums successfully (#425)
  (by @fantix in bb7522c for #419)

* Add optional default to codegen params (#426)
  (by @fantix in 21b024a for #422)

Changes
=======

* blocking client: fix connect and timeout, support IPv6 (#499)
  (by @fantix @zachary822 in 28a83fd for #486)

Fixes
=====

* Add test to check setting a computed global using with_globals. (#494)
  (by @dnwpark in 636bc0e for #494)

* Fix test and add Python 3.12 in CI
  (by @fantix in #498 #503)

* Use result of pydantic_dataclass, will silence linters (#501)
  (by @AdrienPensart in d88187a)

* Extract ExecuteContext as in/out argument (#500)
  (by @fantix in 2fb7965 for #493)
@fantix fantix mentioned this pull request Jun 19, 2024
fantix added a commit that referenced this pull request Jun 19, 2024
New Features
============

* Support EdgeDB 5.0 "branch" connection option
  (by @vpetrovykh in #484 #485 #487)

* Support EdgeDB 5.0 AI extension
  (by @fantix in #489 #490)

Breaking Changes
================

* Enum values can now compare to user-defined enums successfully (#425)
  (by @fantix in bb7522c for #419)

* Add optional default to codegen params (#426)
  (by @fantix in 21b024a for #422)

Changes
=======

* blocking client: fix connect and timeout, support IPv6 (#499)
  (by @fantix @zachary822 in 28a83fd for #486)

Fixes
=====

* Add test to check setting a computed global using with_globals. (#494)
  (by @dnwpark in 636bc0e for #494)

* Fix test and add Python 3.12 in CI
  (by @fantix in #498 #503)

* Use result of pydantic_dataclass, will silence linters (#501)
  (by @AdrienPensart in d88187a)

* Extract ExecuteContext as in/out argument (#500)
  (by @fantix in 2fb7965 for #493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated Enum types are not valid as parameters
2 participants