Lowercase org/instance name when computing Cloud instance DNS #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsidnev
approved these changes
Jun 10, 2023
elprans
force-pushed
the
cloud-dns
branch
8 times, most recently
from
269b3c3
to
619788d
Compare
fantix
approved these changes
Jun 13, 2023
edgedb/_testbase.py
Outdated
| if env.get('ACTIONS_STEP_DEBUG'): | ||
| env['EDGEDB_DEBUG_SERVER'] = '1' | ||
|
|
||
| if env.get('EDGEDB_DEBUG_SERVER') or True: |
There was a problem hiding this comment.
CI passed now 🎉 a kind reminder to drop the debugging before merging.
edgedb/_testbase.py
Outdated
| server_stdout = subprocess.DEVNULL | ||
| server_stdout = server_stderr = subprocess.DEVNULL | ||
|
|
||
| env['EDGEDB_DEBUG_PGSERVER'] = '1' |
There was a problem hiding this comment.
here too - or maybe we want to have the same if env.get('ACTIONS_STEP_DEBUG'): here? Like we never look at the output if the tests passed, or we'll probably want to see (or tolerate some noise) the pg details if there is an error.
fantix
pushed a commit
that referenced
this pull request
Jun 18, 2023
Merged
fantix
pushed a commit
that referenced
this pull request
Jun 19, 2023
fantix
added a commit
that referenced
this pull request
Jun 21, 2023
Changes ======= * Add --dir option to codegen for searching .edgeql files (#434) (by @fantix in ec90e35 for #434) * Implement support for vector type (#439 #440) (by @msullivan in 0bee718 for #439, 50a25ef for #440) * Lowercase org/instance name when computing Cloud instance DNS (#441) (by @elprans in 0f30b26 for #441) * Implement `database` config in project dir (#442) (by @tailhook in bee7327 for #442)
Merged
fantix
added a commit
that referenced
this pull request
Jun 22, 2023
Changes ======= * Add --dir option to codegen for searching .edgeql files (#434) (by @fantix in ec90e35 for #434) * Implement support for vector type (#439 #440) (by @msullivan in 0bee718 for #439, 50a25ef for #440) * Lowercase org/instance name when computing Cloud instance DNS (#441) (by @elprans in 0f30b26 for #441) * Implement `database` config in project dir (#442) (by @tailhook in bee7327 for #442)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.