Add a rudimentary warning system #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this initial iteration of it, warnings are encoded in JSON as a header for CommandDataDescription. A `warning_handler` field is added to `Options`, and it is invoked if any warnings occured. We provide two built-in functions: `log_warnings` and `raise_warnings`. The default is `log_warnings`.
msullivan
changed the title
fantix
added a commit
that referenced
this pull request
Oct 3, 2024
Changes ======= * Add geometry, geography, box2d, and box3d PostGIS types (#518) (by @vpetrovykh in 65d5cdc) * Add a rudimentary warning system (#523) (by @msullivan in 29370f2) Fixes ===== * use StopIteration.value in blocking client _iter_coroutine (#508) (by @graingert in d0e9ed1)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this initial iteration of it, warnings are encoded in JSON as a
header for CommandDataDescription.
A
warning_handlerfield is added toOptions, and it is invoked ifany warnings occured. We provide two built-in functions:
log_warningsandraise_warnings. The default islog_warnings.