-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Device network interfaces #231
Merged
rbino
merged 3 commits into
edgehog-device-manager:main
from
szakhlypa:device-network-interface-backend
Dec 23, 2022
Merged
[backend] Device network interfaces #231
rbino
merged 3 commits into
edgehog-device-manager:main
from
szakhlypa:device-network-interface-backend
Dec 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add module to pull Astarte on the NetworkInterfaceProperties interface Signed-off-by: Sergey Zakhlypa <sergey.zakhlypa@secomind.com>
- Add corresponding mock for testing purposes Signed-off-by: Sergey Zakhlypa <sergey.zakhlypa@secomind.com>
Pull Request Test Coverage Report for Build 7c111bb0149d4be4e802a5e749e00837c5894795-PR-231
💛 - Coveralls |
rbino
approved these changes
Dec 14, 2022
rbino
requested changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry
Signed-off-by: Sergey Zakhlypa <sergey.zakhlypa@secomind.com>
rbino
approved these changes
Dec 21, 2022
rbino
approved these changes
Dec 21, 2022
Pull Request Test Coverage Report for Build 7c111bb0149d4be4e802a5e749e00837c5894795-PR-231Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch NetworkInterfaceProperties data from AppEngine and expose it via GraphQL