Update Campaigns Execution #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbino
force-pushed
the
update-campaigns-execution
branch
2 times, most recently
from
6c47f26
to
1d30f79
Compare
Pull Request Test Coverage Report for Build 44d0e6f468499a5304e6633ec7b4abb31983d249-PR-299Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
rbino
force-pushed
the
update-campaigns-execution
branch
2 times, most recently
from
b0d1b58
to
a59388d
Compare
rbino
force-pushed
the
update-campaigns-execution
branch
from
a59388d
to
16d16ae
Compare
szakhlypa
suggested changes
Jul 3, 2023
backend/test/edgehog/update_campaigns/push_rollout/core_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog/update_campaigns/push_rollout/core_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog/update_campaigns/push_rollout/core_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog/update_campaigns/push_rollout/core_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog/update_campaigns/push_rollout/core_test.exs
Outdated
Show resolved
Hide resolved
rbino
force-pushed
the
update-campaigns-execution
branch
3 times, most recently
from
c40850a
to
6725cc8
Compare
noaccOS
requested changes
Jul 6, 2023
backend/test/edgehog/update_campaigns/push_rollout/core_test.exs
Outdated
Show resolved
Hide resolved
rbino
force-pushed
the
update-campaigns-execution
branch
from
6725cc8
to
ab251cf
Compare
szakhlypa
reviewed
Jul 7, 2023
rbino
force-pushed
the
update-campaigns-execution
branch
3 times, most recently
from
85b3903
to
bad60f2
Compare
rbino
force-pushed
the
update-campaigns-execution
branch
from
bad60f2
to
a060aa8
Compare
szakhlypa
suggested changes
Jul 11, 2023
rbino
force-pushed
the
update-campaigns-execution
branch
6 times, most recently
from
b55d829
to
ad6694e
Compare
rbino
force-pushed
the
update-campaigns-execution
branch
4 times, most recently
from
1c125e5
to
6a6d7a5
Compare
Pavinati
reviewed
Jul 12, 2023
Allow passing device attributes Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
Allow differentiating between a campaign that has already started its rollout from one that has not Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
- retry_count: count the number of retries for the target - latest_attempt: save the timestamp of the latest attempt - ota_operation_id: saves the OTA operation associated with a target - completion_timestamp: stores the moment where the target reached a final state Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
This is more coherent with the naming in the rollout mechanism, which is max_in_progress_updates. Pending also was ambiguous since it had the same name than the pending OTA Operation, while here we represent the whole range of states between the start of the rollout and the completion. Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
Allow to know when an update campaign effectively started and when it finished Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
Helpful for future tests involving targets Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
Allow subscribing and publishing events across the application. Implement the first set of publish primitives for OTAOperation. Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
Also add tests for this Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
Allow the campaign executor to resend the request to the device Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
rbino
force-pushed
the
update-campaigns-execution
branch
from
4914bfc
to
44d0e6f
Compare
noaccOS
reviewed
Jul 13, 2023
backend/test/edgehog/update_campaigns/push_rollout/executor_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog/update_campaigns/push_rollout/executor_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog/update_campaigns/push_rollout/executor_test.exs
Outdated
Show resolved
Hide resolved
backend/test/edgehog/update_campaigns/push_rollout/executor_test.exs
Outdated
Show resolved
Hide resolved
Expose a functional core to be called by the PushRollout executor. Also add relevant tests. Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
Handy Elixir wrapper around gen_statem Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
rbino
force-pushed
the
update-campaigns-execution
branch
from
44d0e6f
to
f70f634
Compare
This is the FSM that is responsible of actually rolling out the Update Campaign. Also add its tests. Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
Start a Registry and a DynamicSupervisor to allow spawning, supervising and identifying the UpdateCampaign executor processes Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
Also add relevant tests Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
rbino
force-pushed
the
update-campaigns-execution
branch
from
f70f634
to
eba076b
Compare
szakhlypa
approved these changes
Jul 14, 2023
noaccOS
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the actual rollout of the Update Campaigns. This makes them functional, with the exception of some corner cases that will be handled in subsequent iterations.