-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize AshGraphQL and port tenantInfo query #430
Merged
szakhlypa
merged 5 commits into
edgehog-device-manager:from-ash-we-rise
from
rbino:ash-tenant-info
Jan 25, 2024
Merged
Initialize AshGraphQL and port tenantInfo query #430
szakhlypa
merged 5 commits into
edgehog-device-manager:from-ash-we-rise
from
rbino:ash-tenant-info
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbino
force-pushed
the
ash-tenant-info
branch
from
January 19, 2024 12:08
1992471
to
d2cd48c
Compare
szakhlypa
reviewed
Jan 19, 2024
Change context population, leveraging Ash Plug helpers Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
rbino
force-pushed
the
ash-tenant-info
branch
2 times, most recently
from
January 22, 2024 16:35
d9fc960
to
c36efd0
Compare
davidebriani
approved these changes
Jan 22, 2024
rbino
force-pushed
the
ash-tenant-info
branch
from
January 23, 2024 16:37
d283228
to
9387275
Compare
szakhlypa
suggested changes
Jan 24, 2024
Remove old manual types and resolver for this. Restore tenant_info query tests, bypassing Phoenix connection when doing so. This is going to be the new standard way to test. Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
Those get exposed by AshGraphql as documentation Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
rbino
force-pushed
the
ash-tenant-info
branch
from
January 24, 2024 15:21
9387275
to
56b0c94
Compare
Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
rbino
force-pushed
the
ash-tenant-info
branch
from
January 24, 2024 16:06
56b0c94
to
0387838
Compare
szakhlypa
approved these changes
Jan 25, 2024
szakhlypa
merged commit Jan 25, 2024
8680066
into
edgehog-device-manager:from-ash-we-rise
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also revamp auth and context generation, leveraging Ash utilities