Let AshJsonApi generate OpenAPI spec #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies related to Ash and AshJsonApi A unit test is changed to accomodate the new error format from AshJsonApi. Signed-off-by: Davide Briani <davide.briani@secomind.com>
Since it is now supported, use AshJsonApi options to configure the OpenAPI spec and use the `spec` function now directly exposed by AshJsonApi. Signed-off-by: Davide Briani <davide.briani@secomind.com>
rbino
approved these changes
Jul 8, 2024
rbino
merged commit cbc94d6
into
edgehog-device-manager:from-ash-we-rise
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a custom
spec/0is defined on theEdgehogWeb.AdminAPImodule whereAshJsonApiis used.The function helps generating the OpenAPI spec and supports the Mix tasks from OpenApiSpex to generate OpenAPI spec files via CLI.
Instead of manually defining the
spec/0function, AshJsonApi introduced support for having the function already defined out of the box: ash-project/ash_json_api#200This PR thus updates AshJsonApi dependency and rely on AshJsonApi's native implementation.