trigger_payload: accept trigger_name key #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build ffb34868d1347e89c11dac69a3b70f0a2701b68e-PR-673Details
💛 - Coveralls |
davidebriani
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks for the fix, the PR is very welcome.
Would you care adding references to the originating issue?
It would be nice to have a quick reference to #664 in the commit, PR description, and CHANGELOG line.
Besides that, as noted in the issue we could also use skip_unknown_inputs so that future additions to Astarte APIs will not break existing Edgehog deployments.
|
Added the references in both places. |
Astarte >= 1.2.0 sends an additional trigger_name key in the trigger payload. This was making Edgehog crash since Ash doesn't accept additional input keys by default. Fix this allowing unknown keys to be accepted. This should future-proof the trigger handler in case further additional keys are added in the future. Since 1.2.0 is the current stable version of Astarte, add the trigger_name key to all existing tests and explicitly test support for the key missing to avoid regressions with old Astarte versions. Fix edgehog-device-manager#664 Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>
davidebriani
approved these changes
Oct 28, 2024
davidebriani
merged commit 1988782
into
edgehog-device-manager:release-0.9
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Astarte >= 1.2.0 sends an additional trigger_name key in the trigger payload. This was making Edgehog crash since Ash doesn't accept additional input keys by default. Fix this allowing unknown keys to be accepted. This should future-proof the trigger handler in case further additional keys are added in the future.
Since 1.2.0 is the current stable version of Astarte, add the trigger_name key to all existing tests and explicitly test support for the key missing to avoid regressions with old Astarte versions.
Fix #664