Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-provider-constellation: openstack support #2974

Merged
merged 5 commits into from
Mar 11, 2024
Merged

terraform-provider-constellation: openstack support #2974

merged 5 commits into from
Mar 11, 2024

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Mar 7, 2024 •
edited
Loading

Context

This adds STACKIT / OpenStack support to the terraform provider.

Proposed change(s)

  • terraform-provider: Add support for STACKIT / OpenStack
  • docs: add STACKIT to the terraform provider page

Additional info

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone
  • needs to be tested more thoroughly (feel free to review the code in the meantime already)

@malt3 malt3 added the feature This introduces new functionality label Mar 7, 2024
@malt3 malt3 added this to the v2.17.0 milestone Mar 7, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 7, 2024 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 86890e2
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65ef182c87d8fc000878e42c

@malt3 malt3 force-pushed the feat/terraform-provider/openstack-support branch from 2cd9ccf to a23a513 Compare March 8, 2024 10:40
@malt3 malt3 marked this pull request as ready for review March 8, 2024 14:25
burgerdev
burgerdev approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but with the reservation that I'm not deep into the terraform provider code.

terraform-provider-constellation/examples/full/stackit/main.tf Outdated Show resolved Hide resolved
@malt3
Copy link
Contributor Author

malt3 commented Mar 11, 2024

@elchead regarding the e2e test: we currently have no way of running automated e2e on this platform.

@malt3 malt3 force-pushed the feat/terraform-provider/openstack-support branch from a23a513 to f293b89 Compare March 11, 2024 13:30
@malt3 malt3 force-pushed the feat/terraform-provider/openstack-support branch from f293b89 to 87303f4 Compare March 11, 2024 14:03
elchead
elchead approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@elchead elchead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this e2e but code lgtm

internal/cloud/openstack/clouds/read.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
docs/versioned_docs/version-2.16/workflows/terraform-provider.md Show resolved Hide resolved
@malt3 malt3 force-pushed the feat/terraform-provider/openstack-support branch from 87303f4 to 86890e2 Compare March 11, 2024 14:41
@malt3 malt3 requested a review from katexochen as a code owner March 11, 2024 14:41
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
cli/internal/cloudcmd 19.50% 18.70% ↘️
cli/internal/cmd 43.20% 42.70% ↘️
cli/internal/terraform 57.30% 57.30% ↔️
internal/cloud/openstack 87.00% 87.00% ↔️
internal/cloud/openstack/clouds 0.00% 0.00% 🆕
internal/config 69.00% 68.60% ↘️
internal/config/migration 0.00% 0.00% 🚧
internal/constellation 19.10% 19.10% 🚧
internal/constellation/helm 34.10% 33.90% ↘️
terraform-provider-constellation/internal/provider 4.20% 4.00% ↘️

@malt3 malt3 merged commit 7fb2a35 into main Mar 11, 2024
13 checks passed
@malt3 malt3 deleted the feat/terraform-provider/openstack-support branch March 11, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elchead elchead elchead approved these changes

@burgerdev burgerdev burgerdev approved these changes

@msanft msanft Awaiting requested review from msanft msanft is a code owner

@derpsteb derpsteb Awaiting requested review from derpsteb derpsteb is a code owner

@thomasten thomasten Awaiting requested review from thomasten thomasten is a code owner

@3u13r 3u13r Awaiting requested review from 3u13r 3u13r is a code owner

@daniel-weisse daniel-weisse Awaiting requested review from daniel-weisse daniel-weisse is a code owner

@katexochen katexochen Awaiting requested review from katexochen katexochen is a code owner

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
v2.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@malt3 @burgerdev @elchead