Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: upgrade cert-manager from v1.12.6 to v1.15.0 #3177

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Jun 19, 2024

Context

Proposed change(s)

  • Upgrade cert-manager to v1.15.0

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@daniel-weisse daniel-weisse added the dependencies Pull requests that update a dependency file label Jun 19, 2024
@daniel-weisse daniel-weisse added this to the v2.17.0 milestone Jun 19, 2024
@daniel-weisse daniel-weisse removed the request for review from derpsteb June 19, 2024 13:32
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 6cbcd43
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6673d14882acd400083118b0

@daniel-weisse daniel-weisse force-pushed the feat/cert-manager/update-chart branch from 78037a1 to 6f47dcd Compare June 19, 2024 13:48
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chart import lgtm.

  1. This probably needs a changelog entry because of the breaking changes from 1.12 to 1.13.
  2. Do we need to consider the upgrade instructions (reset-then-reuse-values)? I wonder whether we might miss something when we just apply the charts.

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse force-pushed the feat/cert-manager/update-chart branch from 6f47dcd to 6cbcd43 Compare June 20, 2024 06:50
Copy link
Contributor

Coverage report

Package Old New Trend
internal/constellation/helm 33.80% 33.80% 🚧

@daniel-weisse
Copy link
Member Author

We don't have any featureGates set, so the breaking change is not an issue.
As for the reset-then-reuse-values, I think @derpsteb probably knows best how the helm charts are configured for upgrade, but I know that we disable value reuse, so we should always use the values from the embedded chart when applying upgrades

@burgerdev
Copy link
Contributor

Number 4 of the breaking changes might affect users, though.

@daniel-weisse
Copy link
Member Author

We can add some notes in the changelog

@daniel-weisse daniel-weisse merged commit a36e1a7 into main Jun 20, 2024
9 checks passed
@daniel-weisse daniel-weisse deleted the feat/cert-manager/update-chart branch June 20, 2024 08:49
@msanft msanft added breaking change Change breaks existing API or configuration. and removed dependencies Pull requests that update a dependency file labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Change breaks existing API or configuration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants