Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: fix gRPC dialing over UDS #3201

Merged
merged 2 commits into from
Jun 25, 2024
Merged

operator: fix gRPC dialing over UDS #3201

merged 2 commits into from
Jun 25, 2024

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Jun 25, 2024

Context

grpc.NewClient uses DNS as default resolver. This does not work for UDS, so we need to specify the resolver explicitly.

Proposed change(s)

Related issue

  • Fixes edgelesssys/issues#711

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@burgerdev burgerdev added the no changelog Change won't be listed in release changelog label Jun 25, 2024
@burgerdev burgerdev added this to the v2.17.0 milestone Jun 25, 2024
@burgerdev burgerdev requested a review from daniel-weisse June 25, 2024 07:06
@burgerdev burgerdev requested a review from 3u13r as a code owner June 25, 2024 07:06
Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 5493dc6
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/667a718c359bd600081b2427

@burgerdev burgerdev changed the title operator: add test for gRPC connection over UDS operator: fix gRPC dialing over UDS Jun 25, 2024
Copy link
Contributor

Coverage report

Package Old New Trend
operators/constellation-node-operator/internal/upgrade 0.00% 52.10% ↗️

@burgerdev burgerdev merged commit 3db3db3 into main Jun 25, 2024
10 checks passed
@burgerdev burgerdev deleted the burgerdev/grpc-resolver branch June 25, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants