Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: cilium: allow multiple default routes #3344

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Sep 9, 2024

Context

Our Cilium hardening scripts assume that there is only one default route configured on the host. However, this turned out to be wrong for some environments, breaking Cilium.

Proposed change(s)

  • Apply hardening to all interfaces used for default routes.

Related issue

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@burgerdev burgerdev added the bug fix Fixing a bug label Sep 9, 2024
@burgerdev burgerdev added this to the v2.18.0 milestone Sep 9, 2024
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 4e87bd7
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/66e004dd3820050008e1390a

Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Haven't deployed a Constellation with it though.

@burgerdev burgerdev force-pushed the burgerdev/patch-multiple-default-routes branch from dcae776 to 4c428fb Compare September 9, 2024 20:59
@burgerdev burgerdev force-pushed the burgerdev/patch-multiple-default-routes branch from 4c428fb to 4e87bd7 Compare September 10, 2024 08:35
Copy link
Contributor

Coverage report

Package Old New Trend
internal/constellation/helm 34.50% 34.50% 🚧

@burgerdev burgerdev merged commit 98f359e into main Sep 10, 2024
22 checks passed
@burgerdev burgerdev deleted the burgerdev/patch-multiple-default-routes branch September 10, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cilium pods don't start on nodes with multiple default routes
2 participants