-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image: unset password reset date to ensure reprodicibility #3466
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
unset instead of hard-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we might want to add a TODO to this indicating that SOURCE_DATE_EPOCH
is not propagated correctly, so that we can at least report it to mkosi some day.
Upsteam qemu-vtpm debug image (build by the CI this branch in https://github.com/edgelesssys/constellation/actions/runs/11608302241):
local image:
|
detailed description
@3u13r: could you please describe in more detail what you are trying to reproduce? What is "Upsteam qemu-vtpm debug image"? |
"Upsteam qemu-vtpm debug image" simply refers to the image you started building in the CI. I've amended the info in the original comment. |
Note that the CI job ran on 4cc5e08, which is not the current HEAD - sorry for that. |
I've updated my original comment with the new image build by the CI. |
The reproducibility issues @3u13r encountered are different and will be addressed in a follow-up PR. |
Context
As part of our
mkosi
build, we add a system useretcd
using thesystemctl-sysusers
mechanism. The tool should understandSOURCE_DATE_EPOCH
, but does not apply it for some reason(maybe missing env propagation in mkosi).Proposed change(s)
Related issue
Additional info
Checklist