Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite speedups extension compilation in setup.py #36

Closed
hodgestar opened this issue Nov 18, 2020 · 0 comments · Fixed by #39
Closed

Rewrite speedups extension compilation in setup.py #36

hodgestar opened this issue Nov 18, 2020 · 0 comments · Fixed by #39

Comments

@hodgestar
Copy link
Contributor

Recent versions of setuptools removed the "Feature' feature again -- pypa/setuptools#2017.

This means we'll need to re-write our setup.py extension building to avoid the use of "Feature". An example of how to do this is shown in pallets/markupsafe#24. We probably want to extend that by providing an environment variable to allow those building Genshi to manually turn speedup compilation on or off.
eli-schwartz added a commit to eli-schwartz/genshi that referenced this issue Mar 3, 2021
@eli-schwartz
setup: do not use deprecated and removed 'Feature' feature
3fa6315 
Emulate it using environment variables instead. $GENSHI_BUILD_SPEEDUP is
checked for existence and parsed as an integer boolean, with invalid
values defaulting (loudly) to 0.

Fixes edgewall#36
@eli-schwartz eli-schwartz mentioned this issue Mar 3, 2021
Merged
eli-schwartz added a commit to eli-schwartz/genshi that referenced this issue Mar 9, 2021
@eli-schwartz
setup: do not use deprecated and removed 'Feature' feature
166f61a 
Emulate it using environment variables instead. $GENSHI_BUILD_SPEEDUP is
checked for existence and parsed as an integer boolean, with invalid
values defaulting (loudly) to 0.

Fixes edgewall#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

setup: do not use deprecated and removed 'Feature' feature eli-schwartz/genshi
1 participant
@hodgestar