Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for msgctxt to i18n #13

Merged
merged 6 commits into from
May 3, 2021
Merged

Conversation

drd
Copy link

@drd drd commented Sep 1, 2018

This is a bit of a blast from the past, but some internet meandering led me to realize that the work I had done at Idealist many years ago to add support for a new i18n:ctxt attribute (think pgettext) never landed. The tests still appear to pass :)

Trac ticket: https://genshi.edgewall.org/ticket/580

@hodgestar
Copy link
Contributor

@drd I know it's been awhile, but would you mind merging master into this branch and then I'll review.

Apologies for this issue taking seven year! 🙈

@spaceone
Copy link

spaceone commented Nov 4, 2020

@hodgestar FYI: in github PR's you can push to the branch if allow edits from maintaines is enabled for this PR. You can simply rebase the branch on master, there are only 3 simple conflicts.

@hodgestar
Copy link
Contributor

@spaceone Thanks! I was actually hoping @drd could take a quick look again so that the code will have had two recent sets of eyes on it when it gets merged. If you're happy to review it with me, that would be awesome (but if not, no worries).

Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small suggestions and I need to see if the tests are passing after my merge of the recent changes, but thank you for dusting this off and submitting it. Much appreciated.

genshi/filters/i18n.py Outdated Show resolved Hide resolved
genshi/filters/i18n.py Outdated Show resolved Hide resolved
@hodgestar
Copy link
Contributor

@drd Thank you for taking the time to resurrect this. I've cleaned it up a bit and am merging.

@hodgestar hodgestar merged commit adedcdd into edgewall:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants