-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for msgctxt to i18n #13
Conversation
@drd I know it's been awhile, but would you mind merging master into this branch and then I'll review. Apologies for this issue taking seven year! 🙈 |
@hodgestar FYI: in github PR's you can push to the branch if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of small suggestions and I need to see if the tests are passing after my merge of the recent changes, but thank you for dusting this off and submitting it. Much appreciated.
@drd Thank you for taking the time to resurrect this. I've cleaned it up a bit and am merging. |
This is a bit of a blast from the past, but some internet meandering led me to realize that the work I had done at Idealist many years ago to add support for a new
i18n:ctxt
attribute (thinkpgettext
) never landed. The tests still appear to pass :)Trac ticket: https://genshi.edgewall.org/ticket/580