port setuptools options to declarative config #40
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| [metadata] | ||
| name = Genshi | ||
| version = 0.8 | ||
| description = A toolkit for generation of output for the web | ||
| long_description = | ||
| Genshi is a Python library that provides an integrated set of | ||
| components for parsing, generating, and processing HTML, XML or | ||
| other textual content for output generation on the web. The major | ||
| feature is a template language, which is heavily inspired by Kid. | ||
| author = Edgewall Software | ||
| author_email = info@edgewall.org | ||
| license = BSD | ||
| license_files = COPYING | ||
| url = https://github.com/edgewall/genshi | ||
| classifiers = | ||
| Development Status :: 4 - Beta | ||
| Environment :: Web Environment | ||
| Intended Audience :: Developers | ||
| License :: OSI Approved :: BSD License | ||
| Operating System :: OS Independent | ||
| Programming Language :: Python | ||
| Programming Language :: Python :: 2 | ||
| Programming Language :: Python :: 3 | ||
| Topic :: Internet :: WWW/HTTP :: Dynamic Content | ||
| Topic :: Software Development :: Libraries :: Python Modules | ||
| Topic :: Text Processing :: Markup :: HTML | ||
| Topic :: Text Processing :: Markup :: XML | ||
| keywords = | ||
| python.templating.engines | ||
|
|
||
| [options] | ||
| # include tests for python3 setup.py test (needed when creating | ||
| # source distributions on python2 too so that they work on python3) | ||
| packages = | ||
| genshi | ||
| genshi.filters | ||
| genshi.template | ||
| genshi.tests | ||
| genshi.filters.tests | ||
| genshi.template.tests | ||
| genshi.template.tests.templates | ||
| install_requires = | ||
| six | ||
|
|
||
| [options.entry_points] | ||
| babel.extractors = | ||
| genshi = genshi.filters.i18n:extract[i18n] | ||
| python.templating.engines = | ||
| genshi = genshi.template.plugin:MarkupTemplateEnginePlugin[plugin] | ||
| genshi-markup = genshi.template.plugin:MarkupTemplateEnginePlugin[plugin] | ||
| genshi-text = genshi.template.plugin:TextTemplateEnginePlugin[plugin] | ||
|
|
||
| [options.extras_require] | ||
| i18n = Babel>=0.8 | ||
| plugin = setuptools>=0.6a2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,63 +98,9 @@ def zip_safe(self): | |
| extra['include_package_data'] = True | ||
|
|
||
|
|
||
| setup( | ||
| test_suite = 'genshi.tests.suite', | ||
|
There was a problem hiding this comment. I don't recall if it's been discussed in this project yet, but the test command is deprecated. There was a problem hiding this comment. That should really be its own issue, and actually this coincides very well with the other mention here about reorganizing into a tests/ directory. There was a problem hiding this comment. Agreed -- let's leave messing with the test suite out of things for now. |
||
|
|
||
| ext_modules = ext_modules, | ||
| cmdclass = cmdclass, | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we put just this line back? I actually prefer if files are explicitly listed in
MANIFEST.inrather than having to guess what other logic elsewhere is including files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine if it is also listed in setup.cfg -- for me that's actually separate information, i.e. "this is a file containing the license" while MANIFEST.in is "please include this file in the source distribution".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a file specifically called out in the metadata, just like
py_modulesorpackages. But instead of declaring it as an importable source file, it's declared as a dist-info file which must be installed as wheel metadata. Since it must be installed as wheel metadata, it also must be included in the source dist in order to guarantee it makes its way into the wheel, and is thus guaranteed to be collected during the dist creation.I disagree with your analysis -- I don't view this as guessable logic -- but if you still want it I'll put it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still like it back -- I have been bitten so often by files not being included in the source distribution that I just want one place that I can look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Apologies for being a pain about it. :|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, I wish every PR review was this simple to solve.
"Looks good, just please include this minor nitpicky line that I really like even though it's a no-op."
(I mean, it's lots better than "I disagree with the functionality and would rather you write your own separate program to do X". I've gotten that once or twice for stuff I thought was a no-brainer bugfix.)