Fix reference leak in Markup.join C implementation #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When support for iterator arguments was added to the Markup.join implementation in 99ad51d the temporary tuple was replaced by a temporary list and a switch was made from
PyTuple_SET_ITEM
(which steals a reference) toPyList_Append
(which does not) without adding the necessaryPy_DECREF
for the added item.This PR adds the necessary reference.
Thanks you @eug3nix for reporting the issue in #46 and helping debug it. Would you mind checking that this PR solves your original issue?