Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new go build tag no_openziti to reduce build size #1637

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

judehung
Copy link
Member

@judehung judehung commented Nov 9, 2024

realetd to edgexfoundry/go-mod-bootstrap#795

As go-mod-bootstrap is updated with new build tag no_openziti with some code refactor, the app-functions-sdk-go also needs to be updated per the refactor.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

realetd to edgexfoundry/go-mod-bootstrap#795

As go-mod-bootstrap is updated with new build tag no_openziti with some
code refactor, the app-functions-sdk-go also needs to be updated per the
refactor.

Signed-off-by: Jude Hung <jude@iotechsys.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.77%. Comparing base (4bf68b1) to head (8e9d93e).

Files with missing lines Patch % Lines
internal/webserver/server.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
+ Coverage   50.46%   50.77%   +0.31%     
==========================================
  Files          62       62              
  Lines        4740     4711      -29     
==========================================
  Hits         2392     2392              
+ Misses       2138     2109      -29     
  Partials      210      210              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@judehung judehung marked this pull request as ready for review November 19, 2024 07:56
@judehung judehung requested a review from cloudxxx8 November 19, 2024 07:56
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 4dc7af8 into edgexfoundry:main Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants