Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change timeout type from int to time.Duration #375

Open
wants to merge 2 commits into
base: jakarta
Choose a base branch
from

Conversation

mursisoy
Copy link

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-modbus-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Add a device profile with Timeout and IdleTimeot with valid strings as stated here: https://pkg.go.dev/time#ParseDuration

New Dependency Instructions (If applicable)

@cloudxxx8 cloudxxx8 added the hold Intended for PRs we want to flag for ongoing review label Sep 19, 2022
@cloudxxx8
Copy link
Member

It's a good idea to use ISO 8601 string to represent the timeout format. However, this is a breaking change. This would break all the existing users with this protocol property. This change needs to be held until 3.0
Also, please follow the contribution guide to open the issue, describe the reason, proper commit message, and DCO.
https://wiki.edgexfoundry.org/display/FA/Committing+Code+Guidelines

@lenny-goodell
Copy link
Member

@cloudxxx8 , looks like this missed the 3.0 release? Should put it on the list for 4.0?
https://github.com/orgs/edgexfoundry/projects/64

@cloudxxx8
Copy link
Member

ok, I just added it to the board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Intended for PRs we want to flag for ongoing review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants