Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps)!: bump sdk to 3.0.0-dev.54 #434

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

weichou1229
Copy link
Member

BREAKING CHANGE: profile resource properties mask,shift,base,scale,offset should use numeric data type instead of string.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-modbus-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) not impact
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) not impact

Testing Instructions

Run unit test and test cmd API.

New Dependency Instructions (If applicable)

BREAKING CHANGE: profile resource properties mask,shift,base,scale,offset should use numeric data type instead of string.

Signed-off-by: bruce <weichou1229@gmail.com>
@weichou1229 weichou1229 requested a review from cloudxxx8 March 21, 2023 05:21
@codecov-commenter
Copy link

Codecov Report

Merging #434 (46775bb) into main (d976059) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   42.52%   42.52%           
=======================================
  Files           6        6           
  Lines         555      555           
=======================================
  Hits          236      236           
  Misses        276      276           
  Partials       43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 82ff0da into edgexfoundry:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants