Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(snap)!: Drop the support for legacy snap env options #454

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

farshidtz
Copy link
Member

  • Drop the support for legacy snap options with env. prefix
  • Upgrade edgex-snap-hooks to v3
  • Upgrade edgex-snap-testing Github action to v3
  • Add snap's Go module to dependabot
  • Other minor refactoring

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-snmp-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
BREAKING CHANGE: Drop the support for deprecated snap options starting with `env.`

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@farshidtz farshidtz marked this pull request as ready for review January 13, 2023 18:43
@farshidtz farshidtz requested a review from MonicaisHer January 13, 2023 18:43
MonicaisHer
MonicaisHer previously approved these changes Jan 17, 2023
Copy link
Contributor

@MonicaisHer MonicaisHer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farshidtz Thank you, looks good!

@MonicaisHer
Copy link
Contributor

Could you please also update the interval for helper-go's go mod from weekly to daily?

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@codecov-commenter
Copy link

Codecov Report

Merging #454 (f91c01f) into main (c9f2a05) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   21.34%   21.34%           
=======================================
  Files           5        5           
  Lines         492      492           
=======================================
  Hits          105      105           
  Misses        374      374           
  Partials       13       13           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@farshidtz farshidtz merged commit bc7652b into edgexfoundry:main Jan 18, 2023
@farshidtz farshidtz deleted the v3-snap-upgrade branch January 18, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants