Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Scheduler improper use of string(len()) to convert int to readable string #2662

Closed
lenny-goodell opened this issue Aug 19, 2020 · 0 comments · Fixed by #2663
Closed

Support Scheduler improper use of string(len()) to convert int to readable string #2662

lenny-goodell opened this issue Aug 19, 2020 · 0 comments · Fixed by #2663
Assignees
@lenny-goodell
Labels
bug Something isn't working fuji geneva

Comments

@lenny-goodell
Copy link
Member

🐞 Bug Report

Affected Services

The issue is located in: support scheduler.

Is this a regression?

No, seems to always have been there. `go vet` with Go 1.15 now exposes it.

Description and Minimal Reproduction

Install Go 1.15
run make test which also run go vet

🔥 Exception or Error

internal/support/scheduler/schedule.go:556:36: conversion from int to string yields a string of one rune, not a string of digits

🌍 Your Environment

Deployment Environment:
Linux
EdgeX Version:
WIP

Anything else relevant?
@lenny-goodell lenny-goodell added the bug Something isn't working label Aug 19, 2020
@lenny-goodell lenny-goodell self-assigned this Aug 19, 2020
lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Aug 19, 2020
fix: Use Itoa() instead of string() for int conversion
e424401 
closes edgexfoundry#2662

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell mentioned this issue Aug 19, 2020
Merged
15 tasks
@lenny-goodell lenny-goodell linked a pull request Aug 19, 2020 that will close this issue
fix: Use Itoa() instead of string() for int conversion #2663
Merged
15 tasks
lenny-goodell added a commit that referenced this issue Aug 19, 2020
@lenny-goodell
fix: Use Itoa() instead of string() for int conversion (#2663)
6df8530 
closes #2662

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenny-goodell lenny-goodell

Labels
bug Something isn't working fuji geneva
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use Itoa() instead of string() for int conversion lenny-goodell/edgex-go
1 participant
@lenny-goodell