Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use Itoa() instead of string() for int conversion #2663

Merged
merged 1 commit into from
Aug 19, 2020
Merged

fix: Use Itoa() instead of string() for int conversion #2663

merged 1 commit into from
Aug 19, 2020

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit subject follows the Conventional Commits spec
  • The commit message follows the EdgeX Contributor Guide
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • make test has completed successfully

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Code was incorrectly using string() to convert int to readable string.

Issue Number: #2662

What is the new behavior?

Code now correctly uses Itoa() to convert the int to a readable string.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

fix: Use Itoa() instead of string() for int conversion
e424401 
closes edgexfoundry#2662

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lenny-goodell lenny-goodell linked an issue Aug 19, 2020 that may be closed by this pull request
Support Scheduler improper use of string(len()) to convert int to readable string #2662
Closed
bnevis-i
bnevis-i approved these changes Aug 19, 2020
View reviewed changes
Copy link
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YIKES!

ernestojeda
ernestojeda approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@ernestojeda ernestojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on 1.15 now

jpwhitemn
jpwhitemn approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@jpwhitemn jpwhitemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 6df8530 into edgexfoundry:master Aug 19, 2020
@lenny-goodell lenny-goodell deleted the fix-string-to-int branch January 14, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnevis-i bnevis-i bnevis-i approved these changes

@jpwhitemn jpwhitemn jpwhitemn approved these changes

@ernestojeda ernestojeda ernestojeda approved these changes

@tonyespy tonyespy Awaiting requested review from tonyespy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Scheduler improper use of string(len()) to convert int to readable string
4 participants
@lenny-goodell @ernestojeda @jpwhitemn @bnevis-i