-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(snap): configure kuiper's REST service port #3770
fix(snap): configure kuiper's REST service port #3770
Conversation
change kuiper's rest service port to 59720 so that this service can be used by edgex Signed-off-by: Mengyi <mengyi.wang@canonical.com>
@siggiskulason Could you please help me add you, @farshidtz and @tonyespy as reviewers? Thank you! |
merge `restPort` into existing port configurations for the kuiper.yaml file Signed-off-by: Mengyi <mengyi.wang@canonical.com>
merge `restPort` into existing port configurations for the kuiper.yaml file Signed-off-by: Mengyi <mengyi.wang@canonical.com>
…icaisHer/edgex-go into snap-modify-kuiper-rest-port
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does the job. Please squash and merge.
In future, we may want to pass this and other build-stage config items as parts.<part-name>.build-environment
to add more visibility into what is being set.
Thanks @MonicaisHer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the test instructions which were clear and to the point. I confirmed that this works as expected.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
change kuiper's rest service port to 59720
so that this service can be used by edgex
fix: #3771
Signed-off-by: Mengyi mengyi.wang@canonical.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Test guidline
snapcraft and install snap:
enable kuiper service and check its restful api port:
expect:
New Dependency Instructions (If applicable)