Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snap): configure kuiper's REST service port #3770

Merged

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Oct 22, 2021

change kuiper's rest service port to 59720
so that this service can be used by edgex
fix: #3771
Signed-off-by: Mengyi mengyi.wang@canonical.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Test guidline

snapcraft and install snap:

git clone https://github.com/MonicaisHer/edgex-go.git
cd edgex-go
git checkout snap-modify-kuiper-rest-port
snapcraft
sudo snap install edgexfoundry_2.0.1-dev.71_amd64.snap --dangerous

enable kuiper service and check its restful api port:

snap set edgexfoundry kuiper=on
snap logs edgexfoundry.kuiper | grep 59720

expect:

2021-10-22T13:08:36Z edgexfoundry.kuiper[14607]: time="2021-10-22 15:08:36" level=info msg="Serving kuiper (version - 1.3.0) on port 20498, and restful api on http://localhost:59720. \n" file="server/server.go:163"
2021-10-22T13:08:36Z edgexfoundry.kuiper[14607]: Serving kuiper (version - 1.3.0) on port 20498, and restful api on http://localhost:59720.

New Dependency Instructions (If applicable)

change kuiper's rest service port to 59720
so that this service can be used by edgex

Signed-off-by: Mengyi <mengyi.wang@canonical.com>
@MonicaisHer MonicaisHer marked this pull request as draft October 22, 2021 13:42
@MonicaisHer MonicaisHer marked this pull request as ready for review October 22, 2021 13:51
@MonicaisHer
Copy link
Contributor Author

@siggiskulason Could you please help me add you, @farshidtz and @tonyespy as reviewers? Thank you!

merge `restPort` into existing port configurations
for the kuiper.yaml file

Signed-off-by: Mengyi <mengyi.wang@canonical.com>
@MonicaisHer MonicaisHer requested a review from farshidtz October 25, 2021 06:18
merge `restPort` into existing port configurations
for the kuiper.yaml file

Signed-off-by: Mengyi <mengyi.wang@canonical.com>
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does the job. Please squash and merge.

In future, we may want to pass this and other build-stage config items as parts.<part-name>.build-environment to add more visibility into what is being set.

Thanks @MonicaisHer

Copy link

@siggiskulason siggiskulason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the test instructions which were clear and to the point. I confirmed that this works as expected.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@siggiskulason siggiskulason merged commit a2b69b2 into edgexfoundry:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different port using by Kuiper's REST API and edgexfoundry snap
3 participants