-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(snap): upgrade kuiper to 1.4.2 #3867
build(snap): upgrade kuiper to 1.4.2 #3867
Conversation
- add `connections` and `portable` directory - specify stream to reuse the connection to EdgeX message bus - remove the override of edgex- sink's port, since the default is 6379 now, which will not collide with app-service-configurable's port Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MonicaisHer
LGTM. I suggest we wait until we complete the relevant tests before merging.
Also, please include the reasoning behind removal of the serviceServer
property in the squash commit message.
b1ec058
to
c83b8d7
Compare
- add `connectionSelector` in `eKuiperEdgeXSourceTemplate` - remove `serviceServer`, since EdgeX v2 does not reply on Core contract Service anymore (reference: https://github.com /lf-edge/ekuiper/blob/master/docs/en_US/edgex/ edgex_rule_engine_tutorial.md#migrate-to-edgex-v2) Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
c83b8d7
to
e1f6ea4
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@farshidtz Thanks a lot for your review. I have added the reasoning behind the removal of the |
For reference, setting |
Issue reported on eKuiper project: lf-edge/ekuiper#1168 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this now and make it available on the beta track, while waiting for lf-edge/ekuiper#1168 to be fixed.
It should be functional as long as the rules set SHARED to true.
- remove `serviceServer`, since EdgeX v2 does not rely on Core contract Service anymore (see: https://github.com/lf-edge/ekuiper/blob/master/docs/en_US/edgex/edgex_rule_engine_tutorial.md#migrate-to-edgex-v2) - remove the override of edgex- sink's port, since the default is 6379 now, which will not collide with app-service-configurable's port - add `connections` and `portable` directory - specify stream to reuse the connection to EdgeX message bus - add `connectionSelector` in `eKuiperEdgeXSourceTemplate` - remove unused kuiper configuration scripts - remove unused kuiper install scripts `rm *.zip` - remove unused comment (cherry picked from commit 85bf44e)
- remove `serviceServer`, since EdgeX v2 does not rely on Core contract Service anymore (see: https://github.com/lf-edge/ekuiper/blob/master/docs/en_US/edgex/edgex_rule_engine_tutorial.md#migrate-to-edgex-v2) - remove the override of edgex- sink's port, since the default is 6379 now, which will not collide with app-service-configurable's port - add `connections` and `portable` directory - specify stream to reuse the connection to EdgeX message bus - add `connectionSelector` in `eKuiperEdgeXSourceTemplate` - remove unused kuiper configuration scripts - remove unused kuiper install scripts `rm *.zip` - remove unused comment (cherry picked from commit 85bf44e) Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
* build(snap): upgrade kuiper to 1.4.2 (#3867) - remove `serviceServer`, since EdgeX v2 does not rely on Core contract Service anymore (see: https://github.com/lf-edge/ekuiper/blob/master/docs/en_US/edgex/edgex_rule_engine_tutorial.md#migrate-to-edgex-v2) - remove the override of edgex- sink's port, since the default is 6379 now, which will not collide with app-service-configurable's port - add `connections` and `portable` directory - specify stream to reuse the connection to EdgeX message bus - add `connectionSelector` in `eKuiperEdgeXSourceTemplate` - remove unused kuiper configuration scripts - remove unused kuiper install scripts `rm *.zip` - remove unused comment (cherry picked from commit 85bf44e) Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com> * build(snap): upgrade kuiper to 1.4.4 Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com> * fix(snap): revert to remove kuiper zip package Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com> Co-authored-by: Mengyi <mengyi.wang@canonical.com>
This PR is to upgrade kuiper to 1.4.2
connectionSelector
to re-use EdgeX message busIf your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
connectionSelector
Expect:
Expect:
New Dependency Instructions (If applicable)