Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(snap): upgrade kuiper to 1.4.4 (Jakarta) #4047

Merged

Conversation

farshidtz
Copy link
Member

@farshidtz farshidtz commented Jun 3, 2022

Cherry picked commit from Kamakura PR:

And added commit for 1.4.2->1.4.4 upgrade.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

MonicaisHer and others added 2 commits June 3, 2022 14:39
- remove `serviceServer`, since EdgeX v2 does not rely on Core contract Service anymore (see: https://github.com/lf-edge/ekuiper/blob/master/docs/en_US/edgex/edgex_rule_engine_tutorial.md#migrate-to-edgex-v2)
- remove the override of edgex- sink's port, since the default is 6379 now, which will not collide with app-service-configurable's port
- add `connections` and `portable` directory
- specify stream to reuse the connection to EdgeX message bus
- add `connectionSelector` in `eKuiperEdgeXSourceTemplate`
- remove unused kuiper configuration scripts
- remove unused kuiper install scripts `rm *.zip`
- remove unused comment

(cherry picked from commit 85bf44e)
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@farshidtz farshidtz requested a review from MonicaisHer June 3, 2022 12:41
Copy link
Contributor

@MonicaisHer MonicaisHer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

farshidtz added 2 commits June 3, 2022 16:12
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #4047 (ee50094) into jakarta (bc2756e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           jakarta    #4047   +/-   ##
========================================
  Coverage    45.84%   45.84%           
========================================
  Files          112      112           
  Lines         9655     9655           
========================================
  Hits          4426     4426           
  Misses        4845     4845           
  Partials       384      384           
Impacted Files Coverage Δ
internal/security/secretstore/secure-messagebus.go 71.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc2756e...ee50094. Read the comment docs.

@farshidtz farshidtz merged commit db608d2 into edgexfoundry:jakarta Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants