Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kong migrations don't run properly #4171

Closed
lenny-goodell opened this issue Sep 29, 2022 · 2 comments · Fixed by #4172
Closed

Kong migrations don't run properly #4171

lenny-goodell opened this issue Sep 29, 2022 · 2 comments · Fixed by #4172
Assignees
Labels
2-medium priority denoting issues with cross-cutting project impact bug Something isn't working ireland jakarta dot - 2.1.1 Jakarta Dot Release 2.1.1 kamakura
Milestone

Comments

@lenny-goodell
Copy link
Member

🐞 Bug Report

Affected Services [REQUIRED]

The issue is located in: cmd/security-bootstrapper/entrypoint-scripts/kong_wait_install.sh

Is this a regression?

No, issue is there since script was created in 2.0.0 (Ireland)

Description and Minimal Reproduction [REQUIRED]

Run Kamakura secure stack compose file
Stop (down) the services w/o clearing volumes
Run latest WIP secure stack compose file with Kong changed to version 2.8 and restart: always commented out.
Note that Kong fails to start with Run 'kong migrations up' to proceed as the last message in the log file
This is because set -e is used a the top of the script which cause the script to exit on error.

🔥 Exception or Error

Kong exits with error from the /docker-entrypoint.sh kong migrations list command in the script.

🌍 Your Environment

N/A

@lenny-goodell lenny-goodell added bug Something isn't working 2-medium priority denoting issues with cross-cutting project impact ireland kamakura jakarta dot - 2.1.1 Jakarta Dot Release 2.1.1 labels Sep 29, 2022
@lenny-goodell lenny-goodell added this to the Levski milestone Sep 29, 2022
@lenny-goodell lenny-goodell self-assigned this Sep 29, 2022
@lenny-goodell
Copy link
Member Author

lenny-goodell commented Sep 29, 2022

@bnevis-i , @JamesKButcher , this bug is in kamakura and jakarta. I put it as a medium, but we should discuss if it is a high and triggers dot releases for kamakura and jakarta. It breaks backwards compatibility.

lenny-goodell pushed a commit to lenny-goodell/edgex-go that referenced this issue Sep 29, 2022
This ensures any missing migration are run and doesn't hurt is there are
none. Non need to run `kong migrations list`

fixes edgexfoundry#4171

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell
Copy link
Member Author

For clarity, backward compatibility here is the ability to run previous 2.x release, stop service w/o wiping data (aka volumes) and run newer 2.x release w/o issues. Currently will fail moving from 2.0.0 => 2.1.1 and moving from 2.1.1 => 2.2.0.

For 2.1.1 => 2.2.0, we can say just skip 2.2.0 and move to 2.3.0 since we are so close to releasing for 2.3.0 with the fix.
The question then becomes do we patch the script in jakarta creating 2.1.2 so upgrade from 2.0.0 => 2.1.2 (LTS) works?

lenny-goodell pushed a commit that referenced this issue Sep 29, 2022
This ensures any missing migration are run and doesn't hurt is there are
none. Non need to run `kong migrations list`

fixes #4171

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-medium priority denoting issues with cross-cutting project impact bug Something isn't working ireland jakarta dot - 2.1.1 Jakarta Dot Release 2.1.1 kamakura
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant