Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace device profile callback with system event #4273

Closed
cloudxxx8 opened this issue Jan 11, 2023 · 0 comments · Fixed by #4336
Closed

Replace device profile callback with system event #4273

cloudxxx8 opened this issue Jan 11, 2023 · 0 comments · Fixed by #4336
Assignees
@jinlinGuan
Labels
enhancement New feature or request

Comments

@cloudxxx8
Copy link
Member

cloudxxx8 commented Jan 11, 2023 •
edited
Loading

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for core-metadata

Description [REQUIRED]

We are replacing Device callback with system event, and we should do the same with device profile
#4235

Describe the solution you'd like

Send out system events for device profile, and remove the callbacks.
Device Services should handle the system events instead of the callback APIs
@cloudxxx8 cloudxxx8 added the enhancement New feature or request label Jan 11, 2023
@github-project-automation github-project-automation bot moved this to New Issues in Technical WG Jan 11, 2023
@cloudxxx8 cloudxxx8 moved this from New Issues to Release Backlog in Technical WG Jan 11, 2023
@cloudxxx8 cloudxxx8 moved this from Release Backlog to In Progress in Technical WG Jan 17, 2023
@cloudxxx8 cloudxxx8 changed the title Replace device service, device profile, and provision watcher callback with system event Replace device profile callback with system event Feb 7, 2023
jinlinGuan added a commit to jinlinGuan/edgex-go that referenced this issue Feb 8, 2023
@jinlinGuan
feat: Implement Device Profile System Events
a60d782 
- publish system events for device profile add/update/delete
- remove the update device profile REST callback

close edgexfoundry#4273
Signed-off-by: Ginny Guan <ginny@iotechsys.com>
@jinlinGuan jinlinGuan mentioned this issue Feb 8, 2023
Merged
5 tasks
jinlinGuan added a commit to jinlinGuan/edgex-go that referenced this issue Feb 8, 2023
@jinlinGuan
feat: Implement Device Profile System Events
7ec95ab 
- publish system events for device profile add/update/delete
- remove the update device profile REST callback

close edgexfoundry#4273
Signed-off-by: Ginny Guan <ginny@iotechsys.com>
lenny-goodell pushed a commit that referenced this issue Feb 8, 2023
@jinlinGuan
feat: Implement Device Profile System Events (#4336)
966ddbc 
- publish system events for device profile add/update/delete
- remove the update device profile REST callback

close #4273
Signed-off-by: Ginny Guan <ginny@iotechsys.com>
@github-project-automation github-project-automation bot moved this from In Progress to Minnesota Done in Technical WG Feb 8, 2023
jinlinGuan added a commit to jinlinGuan/edgex-go that referenced this issue Feb 10, 2023
@jinlinGuan
feat: Update Device Profile System Event Owner
de2c773 
change device profile system event owner from core-metadata to deivce service name

related edgexfoundry#4273

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
@jinlinGuan jinlinGuan mentioned this issue Feb 10, 2023
Merged
5 tasks
jinlinGuan added a commit to jinlinGuan/edgex-go that referenced this issue Feb 13, 2023
@jinlinGuan
feat: Publish Update Device Profile System Event for Each Device Service
3ca4339 
publish update device profile system events to deivce services

related edgexfoundry#4273

Signed-off-by: Ginny Guan <ginny@iotechsys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinlinGuan jinlinGuan

Labels
enhancement New feature or request
Projects
Technical WG
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement Device Profile System Events jinlinGuan/edgex-go
2 participants
@cloudxxx8 @jinlinGuan