Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove old metrics collection and REST endpoint for all services #4311

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

vli11
Copy link
Contributor

@vli11 vli11 commented Jan 27, 2023

Closes: #4307
Signed-off-by: Valina Li valina.li@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

make docker
make test

New Dependency Instructions (If applicable)

@vli11 vli11 requested a review from lenny-goodell January 27, 2023 18:42
@vli11 vli11 self-assigned this Jan 30, 2023
@vli11 vli11 added the enhancement New feature or request label Jan 30, 2023
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the commit message and PR title/description are update for Breaking Change.

@vli11 vli11 force-pushed the remove_old_metrics branch from b403697 to f663c6a Compare January 30, 2023 23:04
@vli11 vli11 changed the title feat: remove old metrics collection and REST endpoint for all services feat!: Remove old metrics collection and REST endpoint for all services Jan 30, 2023
BREAKING CHANGE: /metrics endpoint no longer available for any service

Closes: edgexfoundry#4307
Signed-off-by: Valina Li <valina.li@intel.com>
@vli11 vli11 force-pushed the remove_old_metrics branch from f663c6a to 1a1e1ea Compare January 30, 2023 23:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vli11 vli11 requested a review from lenny-goodell January 30, 2023 23:17
lenny-goodell pushed a commit to lenny-goodell/edgex-taf that referenced this pull request Jan 31, 2023
This enpoint is being removed in edgexfoundry/edgex-go#4311 and future PRs for App and Device SDKs

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cherrycl pushed a commit to edgexfoundry/edgex-taf that referenced this pull request Jan 31, 2023
This enpoint is being removed in edgexfoundry/edgex-go#4311 and future PRs for App and Device SDKs

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell merged commit 4ba88bb into edgexfoundry:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove old metrics collection and REST endpoint for all services
2 participants