Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate spdx sbom and add Makefile target for sbom generation #4339

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

jim-wang-intel
Copy link
Contributor

Closes: #4173

Signed-off-by: Jim Wang yutsung.jim.wang@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • [x ] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

  • git clone this branch
  • run make sbom and it should run successfully and produce sbom under the directory sbom\

New Dependency Instructions (If applicable)

spdx docker container used for generating spdx-sbom: https://github.com/opensbom-generator/spdx-sbom-generator

@jim-wang-intel jim-wang-intel added enhancement New feature or request security_audit Track issues that are related to CVE/CVSS/CWE auditing etc labels Feb 9, 2023
@bnevis-i
Copy link
Collaborator

bnevis-i commented Feb 9, 2023

Pretty cool! @lenny-intel do you think we should be checking in the resulting SBOM?

Copy link
Contributor

@ernestojeda ernestojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

sbom/bom-go-mod.spdx Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@jim-wang-intel
Copy link
Contributor Author

Pretty cool! @lenny-intel do you think we should be checking in the resulting SBOM?

Thanks and good question, @bnevis-i ; depending on what is the satisfying requirement for complying that description about In order to help companies comply with US Executive Order (EO) 14028, Improving the Nation’s Cybersecurity (May 12, 2021). i.e if the artifacts are required in github repo then the answer is yes or just having a way to generate SBOM in spdx format.

Closes: edgexfoundry#4173

Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
@jim-wang-intel jim-wang-intel force-pushed the add_generate_spdx_sbom branch from d3b8725 to 146895f Compare March 9, 2023 16:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jim-wang-intel jim-wang-intel marked this pull request as ready for review March 9, 2023 16:26
Copy link
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnevis-i bnevis-i merged commit da675bb into edgexfoundry:main Mar 10, 2023
@bnevis-i bnevis-i deleted the add_generate_spdx_sbom branch March 10, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security_audit Track issues that are related to CVE/CVSS/CWE auditing etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect and publish SPDX SBOM data for EdgeX releases
3 participants