-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate spdx sbom and add Makefile target for sbom generation #4339
feat: generate spdx sbom and add Makefile target for sbom generation #4339
Conversation
Pretty cool! @lenny-intel do you think we should be checking in the resulting SBOM? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
Thanks and good question, @bnevis-i ; depending on what is the satisfying requirement for complying that description about |
Closes: edgexfoundry#4173 Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
d3b8725
to
146895f
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #4173
Signed-off-by: Jim Wang yutsung.jim.wang@intel.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
make sbom
and it should run successfully and produce sbom under the directory sbom\New Dependency Instructions (If applicable)
spdx docker container used for generating spdx-sbom: https://github.com/opensbom-generator/spdx-sbom-generator