Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor service client usage to remove EndpointerParams and correct signatures #2370

Merged
merged 9 commits into from
Feb 19, 2020
Merged

Refactor service client usage to remove EndpointerParams and correct signatures #2370

merged 9 commits into from
Feb 19, 2020

Conversation

brandonforster
Copy link
Contributor

@brandonforster brandonforster commented Feb 13, 2020 •
edited
Loading

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently, edgex-go is out of sync with changes that have been made in go-mod-core-contracts.

Issue Number: Fixes #2354
Fixes #2237

What is the new behavior?

Usages of service clients have been updated to include the new signatures.

Does this PR introduce a breaking change?

There are no breaking changes relative to edgex-go.

@brandonforster brandonforster self-assigned this Feb 13, 2020
@codecov-io
Copy link

codecov-io commented Feb 13, 2020 •
edited
Loading

Codecov Report

Merging #2370 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2370      +/-   ##
==========================================
+ Coverage   37.56%   37.63%   +0.07%     
==========================================
  Files         157      157              
  Lines       12787    13073     +286     
==========================================
+ Hits         4803     4920     +117     
- Misses       7723     7887     +164     
- Partials      261      266       +5
Impacted Files Coverage Δ
internal/core/data/valuedescriptor.go 49.51% <0%> (-2.36%) ⬇️
internal/core/metadata/rest_deviceprofile.go 89.82% <0%> (-0.95%) ⬇️
internal/core/metadata/rest_device.go 1.79% <0%> (-0.42%) ⬇️
internal/core/data/init.go 0% <0%> (ø) ⬆️
internal/core/command/init.go 0% <0%> (ø) ⬆️
...rnal/core/metadata/operators/device_profile/get.go 100% <0%> (ø) ⬆️
internal/core/metadata/init.go 0% <0%> (ø) ⬆️
...adata/operators/device_profile/value_descriptor.go 99.21% <0%> (+1.54%) ⬆️
internal/core/data/event.go 65.1% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4cde2c...2664e7b. Read the comment docs.

michaelestrin
michaelestrin suggested changes Feb 13, 2020
View reviewed changes
internal/core/command/init.go Outdated Show resolved Hide resolved
internal/core/data/init.go Outdated Show resolved Hide resolved
internal/core/metadata/rest_device.go Outdated Show resolved Hide resolved
internal/core/metadata/rest_deviceprofile.go Show resolved Hide resolved
internal/pkg/endpoint/endpoint.go Outdated Show resolved Hide resolved
@brandonforster brandonforster mentioned this pull request Feb 13, 2020
Closed
michaelestrin
michaelestrin suggested changes Feb 14, 2020
View reviewed changes
internal/pkg/endpoint/endpoint.go Outdated Show resolved Hide resolved
internal/pkg/endpoint/endpoint.go Outdated Show resolved Hide resolved
internal/pkg/endpoint/endpoint.go Outdated Show resolved Hide resolved
internal/core/metadata/rest_device.go Show resolved Hide resolved
internal/core/metadata/rest_deviceprofile.go Show resolved Hide resolved
internal/system/agent/direct/metrics.go Outdated Show resolved Hide resolved
internal/system/agent/getconfig/executor.go Outdated Show resolved Hide resolved
@brandonforster
#2354: Updated usages of Context to match contracts and be idiomatic.
5a497fc 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster
#2354: Updated folding.
a33ca86 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster
#2354: Addressed PR feedback.
51e6c65 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster
#2354: Added missing whitespace.
a0fc72c 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster
#2354: Updated with PR feedback.
b24341c 
Signed-off-by: Brandon Forster <me@brandonforster.com>
michaelestrin
michaelestrin suggested changes Feb 14, 2020
View reviewed changes
internal/pkg/endpoint/endpoint.go Outdated Show resolved Hide resolved
internal/pkg/endpoint/endpoint.go Outdated Show resolved Hide resolved
internal/pkg/endpoint/endpoint.go Outdated Show resolved Hide resolved
internal/pkg/endpoint/endpoint.go Outdated Show resolved Hide resolved
@brandonforster
#2354: Redid Endpoint algorithm.
dd5e45f 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster
#2354: Refactored urlclient.New to stop Monitor from being called eve…
23a2bb5 
…ry time.

Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster
Copy link
Contributor Author

recheck

@michaelestrin
Copy link
Member

Please address the build failure so code can be reviewed/merged. Rerequest review once complete.

image

@brandonforster

@brandonforster
Copy link
Contributor Author

recheck

@brandonforster
Updated to use bootstrap PR #51
d4cde2c 
Signed-off-by: Brandon Forster <me@brandonforster.com>
@brandonforster
Copy link
Contributor Author

Screen Shot 2020-02-19 at 11 00 44 AM

@michaelestrin You didn't leave a review to re-request, only a comment. I can't re-request off a comment.

Jenkins was broken; hopefully it's fixed now.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.3% 3.3% Duplication

michaelestrin
michaelestrin approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@michaelestrin michaelestrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending successful build.

@brandonforster brandonforster merged commit 93a900b into edgexfoundry:master Feb 19, 2020
@brandonforster brandonforster deleted the issue_2354 branch February 19, 2020 20:37
akramtexas pushed a commit to akramtexas/edgex-go that referenced this pull request Feb 19, 2020
@brandonforster @akramtexas
Refactor service client usage to remove EndpointerParams and correct …
ed6b0ee 
…signatures (edgexfoundry#2370)

Signed-off-by: Brandon Forster <me@brandonforster.com>

Review V1 Swagger (SMA) for completeness.

Signed-off-by: Akram Ahmad <sftwr2020@gmail.com>

Add missing info to the V1 Swagger (SMA).

Signed-off-by: Akram Ahmad <sftwr2020@gmail.com>
akramtexas pushed a commit to akramtexas/edgex-go that referenced this pull request Feb 19, 2020
@brandonforster @akramtexas
Refactor service client usage to remove EndpointerParams and correct …
ba35488 
…signatures (edgexfoundry#2370)

Signed-off-by: Brandon Forster <me@brandonforster.com>

Signed-off-by: Akram Ahmad <sftwr2020@gmail.com>
This was referenced Feb 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelestrin michaelestrin michaelestrin approved these changes

Assignees

@brandonforster brandonforster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate go-mod-contracts changes to service clients Address core-command Blackbox Test Failure
3 participants
@brandonforster @codecov-io @michaelestrin