feat(data): Implement GET /event/device/name/{name} V2 API #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2847 +/- ##
==========================================
+ Coverage 38.81% 39.71% +0.89%
==========================================
Files 145 166 +21
Lines 12722 13636 +914
==========================================
+ Hits 4938 5415 +477
- Misses 7510 7894 +384
- Partials 274 327 +53
Continue to review full report at Codecov.
|
lenny-goodell
requested changes
Oct 23, 2020
weichou1229
changed the title
|
Modified. |
|
please rebase and resolve the conflicts |
|
Resolved conflicts and rebased. |
|
recheck |
cloudxxx8
requested changes
Oct 26, 2020
Implement CoreData GET /event/device/name/{name} API to query events by offset, limit and device name.
Fix #2842
Signed-off-by: weichou <weichou1229@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
lenny-goodell
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2842
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Issue Number: #2842
What is the new behavior?
Implement CoreData GET /event/deice/name/{name} API to query events by offset, limit and device name.
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information