fix(metadata): fix V2 API int overflow error on 32bit ARM build #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2872 +/- ##
==========================================
+ Coverage 39.33% 40.12% +0.79%
==========================================
Files 166 172 +6
Lines 13961 14246 +285
==========================================
+ Hits 5491 5716 +225
- Misses 8140 8163 +23
- Partials 330 367 +37
Continue to review full report at Codecov.
|
cloudxxx8
requested changes
Nov 6, 2020
Since 32bits ARCH only support 2,147,483,647 as the maximum positive signed integer, so use math.MaxInt32 instead of the math.MaxUint32. Fix #2870 Signed-off-by: weichou <weichou1229@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
No problem, modified. |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2870
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Golang build failed with 32bits ARCH
Issue Number: #2870
What is the new behavior?
Since 32bits ARCH only support 2,147,483,647 as the maximum positive signed integer, so use math.MaxInt32 instead of the math.MaxUint32.
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information