Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(snap): Update edgex-snap-hooks to 2.3.1 #4071

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Jul 4, 2022

There are some additional changes to correctly load env files. The new version of the dependency fixes the syntax of env files; see canonical/edgex-snap-hooks#52

Signed-off-by: Mengyi Wang mengyi.wang@canonical.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #4071 (b462043) into main (33a3e4f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4071   +/-   ##
=======================================
  Coverage   47.27%   47.27%           
=======================================
  Files         114      114           
  Lines        9850     9850           
=======================================
  Hits         4657     4657           
  Misses       4805     4805           
  Partials      388      388           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a3e4f...b462043. Read the comment docs.

@farshidtz farshidtz self-requested a review July 4, 2022 10:08
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Testing by running the following:

$ sudo snap set edgexfoundry app-options=true
$ sudo snap set edgexfoundry config.service-startupmsg="pr-4071"
$ sudo snap set edgexfoundry apps.core-data.config.service-port=55555
$ sudo snap stop edgexfoundry
$ sudo snap start edgexfoundry # this will start everything...

$ snap logs -n=1000 edgexfoundry | grep pr-4071
2022-07-04T14:11:46+02:00 edgexfoundry.core-command[206706]: level=INFO ts=2022-07-04T12:11:46.253157091Z app=core-command source=variables.go:352 msg="Variables override of 'Service.StartupMsg' by environment variable: SERVICE_STARTUPMSG=pr-4071"
2022-07-04T14:11:47+02:00 edgexfoundry.core-data[206772]: level=INFO ts=2022-07-04T12:11:47.558967734Z app=core-data source=variables.go:352 msg="Variables override of 'Service.StartupMsg' by environment variable: SERVICE_STARTUPMSG=pr-4071"
2022-07-04T14:11:48+02:00 edgexfoundry.core-metadata[206834]: level=INFO ts=2022-07-04T12:11:48.935433545Z app=core-metadata source=variables.go:352 msg="Variables override of 'Service.StartupMsg' by environment variable: SERVICE_STARTUPMSG=pr-4071"

$ snap logs -n=1000 edgexfoundry | grep 55555
2022-07-04T14:16:44+02:00 edgexfoundry.core-data[210076]: level=INFO ts=2022-07-04T12:16:44.522463149Z app=core-data source=variables.go:352 msg="Variables override of 'Service.Port' by environment variable: SERVICE_PORT=55555"
2022-07-04T14:16:44+02:00 edgexfoundry.core-data[210076]: level=INFO ts=2022-07-04T12:16:44.541090074Z app=core-data source=variables.go:352 msg="Variables override of 'Service.Port' by environment variable: SERVICE_PORT=55555"
2022-07-04T14:16:44+02:00 edgexfoundry.core-data[210076]: level=INFO ts=2022-07-04T12:16:44.607399681Z app=core-data source=httpserver.go:131 msg="Web server starting (localhost:55555)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants