Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Test on go mod version #4105

Closed

Conversation

jim-wang-intel
Copy link
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Closes: edgexfoundry#3257

Signed-off-by: Jim Wang (Intel) <yutsung.jim.wang@intel.com>
…gent related access rights

Signed-off-by: Jim Wang (Intel) <yutsung.jim.wang@intel.com>
Signed-off-by: Jim Wang (Intel) <yutsung.jim.wang@intel.com>
Signed-off-by: Jim Wang (Intel) <yutsung.jim.wang@intel.com>
@jim-wang-intel jim-wang-intel changed the title Test on go mod version DO NOT MERGE: Test on go mod version Jul 28, 2022
Signed-off-by: Jim Wang (Intel) <yutsung.jim.wang@intel.com>
Signed-off-by: Jim Wang (Intel) <yutsung.jim.wang@intel.com>
Signed-off-by: Jim Wang (Intel) <yutsung.jim.wang@intel.com>
Signed-off-by: Jim Wang (Intel) <yutsung.jim.wang@intel.com>
@jim-wang-intel jim-wang-intel force-pushed the test-on-go-mod-version branch from 5ebe4c5 to e3b220e Compare July 28, 2022 20:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #4105 (5ebe4c5) into main (062af8d) will increase coverage by 0.06%.
The diff coverage is 72.72%.

❗ Current head 5ebe4c5 differs from pull request most recent head e3b220e. Consider uploading reports for the commit e3b220e to get more accurate results

@@            Coverage Diff             @@
##             main    #4105      +/-   ##
==========================================
+ Coverage   47.32%   47.39%   +0.06%     
==========================================
  Files         114      114              
  Lines        9850     9869      +19     
==========================================
+ Hits         4662     4677      +15     
- Misses       4801     4803       +2     
- Partials      387      389       +2     
Impacted Files Coverage Δ
.../security/bootstrapper/command/setupacl/command.go 72.32% <72.72%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062af8d...e3b220e. Read the comment docs.

@lenny-goodell
Copy link
Member

This help figure out the issue. no longer needed

@jim-wang-intel jim-wang-intel deleted the test-on-go-mod-version branch July 29, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants