feat(command): refine north-south messaging configuration #4185

chr1shung · 2022-10-06T03:49:49Z

Signed-off-by: Chris Hung chris@iotechsys.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
I am not introducing a new dependency (add notes below if you are)
I have added unit tests for the new feature or bug fix (if not, why?)
I have fully tested (add details below) this the new feature or bug fix (if not, why?)
I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

cloudxxx8

LGTM

codecov-commenter · 2022-10-06T04:30:29Z

Codecov Report

Merging #4185 (b705be0) into main (07636ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4185   +/-   ##
=======================================
  Coverage   43.51%   43.51%           
=======================================
  Files         126      126           
  Lines       11149    11149           
=======================================
  Hits         4852     4852           
  Misses       5878     5878           
  Partials      419      419

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lenny-goodell · 2022-10-10T16:55:22Z

internal/core/command/main.go

@@ -111,6 +109,11 @@ func MessageBusBootstrapHandler(ctx context.Context, wg *sync.WaitGroup, startup
 			return false
 		}
 	}
+	if configuration.MessageQueue.External.Enabled {


I think this check should be within if configuration.RequireMessageBus scope since receiving external message doesn't make sense if we are not connected to the internal message bus to send them to the device services