refactor!: Replace internal topics from config with new constants

[lenny-goodell]

BREAKING CHANGE: Internal topics no longer configurable, except the base topic.

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

• I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
• I am not introducing a new dependency (add notes below if you are)
• I have added unit tests for the new feature or bug fix (if not, why?)
• I have fully tested (add details below) this the new feature or bug fix (if not, why?)
• I have opened a PR for the related docs change (if not, why?)
  TBD

Testing Instructions

1. run make docker do build local images

2. from compose builder run make run no-secty ds-virtual dev mqtt-broker

3. Using MQTT tool verify external MQTT commands work

   • Subscribe to edgex/command/response/#
   • Publish the following to edgex/command/request/Random-Integer-Device/Int16/get

   {
      "Correlation-ID": "14a42ea6-c394-41c3-8bcd-a29b9f5e6835",
      "apiVersion": "v2",
      "requestId": "e6e8a2f4-eb14-4649-9e2b-175247911369",
      "ContentType": "application/json",
      "queryParams": {
         "ds-pushevent":"true",
         "ds-returnevent":"true"
       }
   }
   

   • Verify valid response is received on subscribed topic.

4. Verify events are recieved by Core Data.

   • Enable DEBUG logging for Core Data
   • Verify logs contain messages like:

   level=DEBUG ts=2023-02-14T22:27:05.1572658Z app=core-data source=subscriber.go:65 msg="Event received from MessageBus. Topic: edgex/events/device/#, Correlation-id: 6c79cbdf-1638-4a9a-b081-afacd3673de1 "
   

New Dependency Instructions (If applicable)

[codecov-commenter]

Codecov Report

Merging #4348 (70fe86c) into main (3a7cf40) will decrease coverage by 0.01%.
The diff coverage is 74.07%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #4348      +/-   ##
==========================================
- Coverage   43.66%   43.66%   -0.01%     
==========================================
  Files         116      116              
  Lines       10701    10707       +6     
==========================================
+ Hits         4673     4675       +2     
- Misses       5609     5612       +3     
- Partials      419      420       +1     

Impacted Files	Coverage Δ
internal/core/data/application/event.go	62.59% <25.00%> (ø)
internal/core/data/controller/http/event.go	82.41% <33.33%> (-1.77%)	⬇️
...rnal/core/command/controller/messaging/external.go	87.62% <100.00%> (+0.12%)	⬆️
...rnal/core/command/controller/messaging/internal.go	50.00% <100.00%> (+0.38%)	⬆️
...nternal/core/command/controller/messaging/utils.go	66.03% <100.00%> (ø)
internal/core/metadata/application/notify.go	33.68% <100.00%> (-0.70%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[jim-wang-intel]

LGTM

[ejlee3]

LGTM