-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add warn log for create/update interval #4597
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4597 +/- ##
==========================================
+ Coverage 41.57% 41.59% +0.02%
==========================================
Files 106 107 +1
Lines 9759 9770 +11
==========================================
+ Hits 4057 4064 +7
- Misses 5356 5360 +4
Partials 346 346
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c974869
to
342f0e5
Compare
Add warn log for interval value from Interval and AutoEvent if the value is less than the suggested value. Closes edgexfoundry#4586. Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
Modify minimum duration param type of CheckMinInterval func to time.Duration. Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
Remove CheckMinInterval return value and verify the mock lc method is called in tests. Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
342f0e5
to
4c96589
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add warn log for interval value from Interval and AutoEvent if the value is less than the suggested value.
Closes #4586.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Invoke the POST interval API with the following command:
The following warning log should be displayed in the support-scheduler log:
New Dependency Instructions (If applicable)