Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add key-related APIs in security-proxy-auth #5039

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

lindseysimple
Copy link
Contributor

@lindseysimple lindseysimple commented Dec 27, 2024

Resolves #5038. Add key-related APIs in security-proxy-auth to enable support for external JWT verification.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.68966% with 143 lines in your changes missing coverage. Please review.

Project coverage is 28.11%. Comparing base (b24805f) to head (c38af36).

Files with missing lines Patch % Lines
...xyauth/infrastructure/interfaces/mocks/DBClient.go 34.92% 20 Missing and 21 partials ⚠️
internal/pkg/infrastructure/postgres/keystore.go 0.00% 31 Missing ⚠️
...ternal/pkg/utils/crypto/interfaces/mocks/Crypto.go 40.47% 13 Missing and 12 partials ⚠️
internal/pkg/utils/crypto/aes.go 67.44% 7 Missing and 7 partials ⚠️
internal/security/proxyauth/application/key.go 81.39% 4 Missing and 4 partials ⚠️
internal/security/proxyauth/router.go 0.00% 7 Missing ⚠️
internal/security/proxyauth/config/config.go 0.00% 4 Missing ⚠️
internal/security/proxyauth/main.go 0.00% 4 Missing ⚠️
internal/security/proxyauth/controller/key.go 94.11% 1 Missing and 1 partial ⚠️
internal/core/command/router.go 0.00% 1 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5039      +/-   ##
==========================================
+ Coverage   27.71%   28.11%   +0.39%     
==========================================
  Files         245      256      +11     
  Lines       18197    18462     +265     
==========================================
+ Hits         5044     5191     +147     
- Misses      11998    12071      +73     
- Partials     1155     1200      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lindseysimple lindseysimple force-pushed the issue-5038 branch 3 times, most recently from 6eb01cb to 48ba4ff Compare December 30, 2024 08:52
@lindseysimple lindseysimple marked this pull request as ready for review January 7, 2025 04:07
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Resolves edgexfoundry#5038. Add key-related APIs in security-proxy-auth to enable support for external JWT verification.

Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
Copy link

sonarqubecloud bot commented Jan 8, 2025

@cloudxxx8 cloudxxx8 merged commit 9ac3255 into edgexfoundry:main Jan 8, 2025
7 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-5038 branch January 8, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add key-related APIs in the security-proxy-auth service to enable support for external JWT verification
3 participants