Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[URI4Files] Go- Refactor loading Config file to handle URI #553

Closed
lenny-goodell opened this issue Jun 6, 2023 · 0 comments · Fixed by #558
Closed

[URI4Files] Go- Refactor loading Config file to handle URI #553

lenny-goodell opened this issue Jun 6, 2023 · 0 comments · Fixed by #558
Labels
enhancement New feature or request
Milestone
Napa

Comments

@lenny-goodell
Copy link
Member

lenny-goodell commented Jun 6, 2023 •
edited
Loading

Refactor GetConfigFileLocation

If value returned by environment.GetConfigFileName starts with http:// or https:// then return this value and ignore values from environment.GetConfigDir and environment.GetProfileDir

Refactor loading of the config files

Change loadConfigYamlFromFile to use LoadFromFIle instead of os.ReadFile
@lenny-goodell lenny-goodell added this to the Napa milestone Jun 6, 2023
@lenny-goodell lenny-goodell added the enhancement New feature or request label Jun 6, 2023
@lenny-goodell lenny-goodell changed the title [URI4Files] Refactor loadConfigYamlFromFile to use new LoadFile function [URI4Files] Refactor loading Config file to use new LoadFile function Jun 6, 2023
@lenny-goodell lenny-goodell changed the title [URI4Files] Refactor loading Config file to use new LoadFile function [URI4Files] Refactor loading Config file to handle URI Jun 6, 2023
@lenny-goodell lenny-goodell mentioned this issue Jun 12, 2023
Open
@lenny-goodell lenny-goodell changed the title [URI4Files] Refactor loading Config file to handle URI [URI4Files] Go- Refactor loading Config file to handle URI Jun 12, 2023
brian-intel added a commit to brian-intel/go-mod-bootstrap that referenced this issue Jun 30, 2023
@brian-intel
feat: Use loadfile that allows reading from local file or uri
195fdb8 
close edgexfoundry#553

Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
brian-intel added a commit to brian-intel/go-mod-bootstrap that referenced this issue Jun 30, 2023
@brian-intel
feat: Use loadfile that allows reading from local file or uri
f7b6b7c 
close edgexfoundry#553

Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
brian-intel added a commit to brian-intel/go-mod-bootstrap that referenced this issue Jun 30, 2023
@brian-intel
feat: Use loadfile that allows reading from local file or uri
078d553 
close edgexfoundry#553

Signed-off-by: Brian McGinn <brian.mcginn@intel.com>
@brian-intel brian-intel mentioned this issue Jun 30, 2023
Merged
5 tasks
lenny-goodell pushed a commit that referenced this issue Jul 17, 2023
@brian-intel
feat: Use loadfile that allows reading from local file or uri (#558)
b171584 
* feat: Use loadfile that allows reading from local file or uri

close #553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Napa
Development

Successfully merging a pull request may close this issue.

feat: Use loadfile that allows reading Config from local file or uri brian-intel/go-mod-bootstrap
1 participant
@lenny-goodell